Skip to content

Fix prometheus metric name and unit conversion #3924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ocelotl merged 7 commits into from
May 28, 2024
Merged

Fix prometheus metric name and unit conversion #3924

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0335dd8
Fix prometheus metric name and unit conversion
aabmass May 20, 2024
07aff62
Apply suggestions from code review
aabmass May 23, 2024
7c729b6
Make annotation parsing more permissive, add test case for consecutiv…
aabmass May 23, 2024
dad9948
Add test case for metric name already containing the unit
aabmass May 23, 2024
a5844da
simplify and speed up regex and update TODO
aabmass May 23, 2024
78ffe92
Add OTEL_PYTHON_EXPERIMENTAL_DISABLE_PROMETHEUS_UNIT_NORMALIZATION op…
aabmass May 23, 2024
d35f4b8
Fix RST typo
aabmass May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Diego Hurtado <[email protected]>
  • Loading branch information
@aabmass @ocelotl
aabmass and ocelotl committed May 28, 2024
commit 07aff6261f6e8e2e775b88cfb1c4eeba8f45b831
4 changes: 2 additions & 2 deletions exporter/opentelemetry-exporter-prometheus/tests/test_mapping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@


class TestMapping(TestCase):
def testsanitize_full_name(self):
def test_sanitize_full_name(self):
self.assertEqual(
sanitize_full_name("valid_metric_name"), "valid_metric_name"
)
Expand Down Expand Up @@ -53,7 +53,7 @@ def testsanitize_full_name(self):
self.assertEqual(sanitize_full_name("TestString"), "TestString")
self.assertEqual(sanitize_full_name("aAbBcC_12_oi"), "aAbBcC_12_oi")

def testsanitize_attribute(self):
def test_sanitize_attribute(self):
self.assertEqual(
sanitize_attribute("valid_attr_key"), "valid_attr_key"
)
Expand Down