fix: compact Dalli attributes #1548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickamorim
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
nickamorim
force-pushed
the
nickamorim/dalli-nil-attributes
branch
from
8c876e2 to
b6c47b1
Compare
oosidat
approved these changes
May 23, 2025
| 'net.peer.name' => hostname, | ||
| 'net.peer.port' => port | ||
| } | ||
| }.compact |
Contributor
There was a problem hiding this comment.
.compact! means one less hash allocation, it can return nil so don't call it on the closing }.
Suggested change
| }.compact | |
| } | |
| attributes.compact! |
nickamorim
force-pushed
the
nickamorim/dalli-nil-attributes
branch
2 times, most recently
from
84f7aa8 to
1b906ed
Compare
robertlaurin
approved these changes
May 23, 2025
Contributor
robertlaurin
left a comment
robertlaurin
left a comment
There was a problem hiding this comment.
Will merge on CI completion
| end | ||
|
|
||
| attributes['peer.service'] = config[:peer_service] if config[:peer_service] | ||
| attributes.compact! |
Contributor
There was a problem hiding this comment.
We typically want to avoid using compact! whenever possilbe since it is a bit slower than conditional assigments.
You can see a benchmark here someone shared:
nickamorim
force-pushed
the
nickamorim/dalli-nil-attributes
branch
from
1b906ed to
2e07695
Compare
arielvalentin
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dalli supports connecting to Memcached over a UNIX domain socket in which case the
portis nil. This will raiseOpenTelemetry error: invalid span attribute value type NilClass for key 'net.peer.port' on span 'set' (OpenTelemetry::Error)(source).This PR attempts to address this by compacting the
attributes. I'm curious if folks think the test is digging too deep into Dalli internals. I just mainly wanted to avoid spinning up a separate Memcached server that is listening over a UNIX domain socket to test this. I'm all ears for other approaches too.