Skip to content

feat: Add experimental traceresponse propagator to Rack instrumentation #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plantfansam merged 14 commits into from
Nov 15, 2022
Merged

feat: Add experimental traceresponse propagator to Rack instrumentation #182

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
dac9594
feat: Add experimental traceresponse propagator to Rack instrumentation
wperron Nov 3, 2022
7b6059b
move to different example
wperron Nov 9, 2022
b2eeeef
use released version and remove pry
wperron Nov 9, 2022
b8bf8d2
add experimental sdk dep in example
wperron Nov 9, 2022
dddde9e
pluralize response propagators option
wperron Nov 9, 2022
0b31cef
add test
wperron Nov 9, 2022
2c598c5
adjust whitespace
wperron Nov 10, 2022
b7d9d27
minor comments
wperron Nov 10, 2022
d95e96b
add case where propagator throws
wperron Nov 14, 2022
6b4f886
remove whitespace from diff
wperron Nov 14, 2022
18763e7
add status code assertion and change case name
wperron Nov 14, 2022
2736718
assert middleware raises on exception
wperron Nov 14, 2022
70c4bb5
Merge branch 'main' into instrumentation-rack-tracesponse
plantfansam Nov 14, 2022
53b4f17
Merge branch 'main' into instrumentation-rack-tracesponse
plantfansam Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
assert middleware raises on exception
  • Loading branch information
@wperron
wperron committed Nov 14, 2022
commit 2736718fdc3bafb9f68c36411568aaf2219c2577
6 changes: 3 additions & 3 deletions ...tation/rack/test/opentelemetry/instrumentation/rack/middlewares/tracer_middleware_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,9 +338,9 @@ def inject(carrier)
let(:config) { default_config.merge(response_propagators: [MockPropagator.new]) }

it 'leads to application errors when there are exceptions' do
res = Rack::MockRequest.new(rack_builder).get('/ping', env)
_(res.headers).wont_include('traceresponse')
_(res.status).must_equal(500)
assert_raises RuntimeError do
Rack::MockRequest.new(rack_builder).get('/ping', env)
end
end
end
end
Expand Down