-
Notifications
You must be signed in to change notification settings - Fork 227
refactor!: Remove parent repo libraries #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
arielvalentin
merged 6 commits into
open-telemetry:main
from
arielvalentin:remove-api-sdk-references
Jun 16, 2022
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7d1754b
refactor!: Remove parent repo libraries
arielvalentin ad9eff9
chore: Fix paths in docs
arielvalentin 87115fd
chore: Remove exporter tests
arielvalentin 3bbc8ec
squash: Fix mongodb tests
arielvalentin a8ce4e5
chore: Fix broken paths in URLs
arielvalentin 77110d4
chore: Fix broken paths in URLs
arielvalentin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,25 +36,25 @@ Fork the project on GitHub by clicking the `Fork` button at the top of the | |
| repository and clone your fork locally: | ||
|
|
||
| ```sh | ||
| git clone [email protected]:YOUR_GITHUB_NAME/opentelemetry-ruby.git | ||
| git clone [email protected]:YOUR_GITHUB_NAME/opentelemetry-ruby-contrib.git | ||
| ``` | ||
|
|
||
| or | ||
| ```sh | ||
| git clone https://github.com/YOUR_GITHUB_NAME/opentelemetry-ruby.git | ||
| git clone https://github.com/YOUR_GITHUB_NAME/opentelemetry-ruby-contrib.git | ||
| ``` | ||
|
|
||
| It can be helpful to add the `open-telemetry/opentelemetry-ruby` repo as a | ||
| It can be helpful to add the `open-telemetry/opentelemetry-ruby-contrib` repo as a | ||
| remote so you can track changes (we're adding as `upstream` here): | ||
|
|
||
| ```sh | ||
| git remote add upstream [email protected]:open-telemetry/opentelemetry-ruby.git | ||
| git remote add upstream [email protected]:open-telemetry/opentelemetry-ruby-contrib.git | ||
| ``` | ||
|
|
||
| or | ||
|
|
||
| ```sh | ||
| git remote add upstream https://github.com/open-telemetry/opentelemetry-ruby.git | ||
| git remote add upstream https://github.com/open-telemetry/opentelemetry-ruby-contrib.git | ||
| ``` | ||
|
|
||
| For more detailed information on this workflow read the | ||
|
|
@@ -90,15 +90,13 @@ configuration details. | |
| The services provided include: | ||
|
|
||
| * `app` - main container environment scoped to the `/app` directory. Used | ||
| primarily to build and tag the `opentelemetry/opentelemetry-ruby:latest` image. | ||
| * `api` - convenience environment scoped to the `api` gem in the `/app/api` directory. | ||
| * `sdk` - convenience environment scoped to the `sdk` gem in the `/app/sdk` directory. | ||
| primarily to build and tag the `opentelemetry/opentelemetry-ruby-contrib:latest` image. | ||
|
|
||
| To test using Docker: | ||
|
|
||
| 1. Install Docker and Docker Compose for your operating system | ||
| 2. Get the latest code for the project | ||
| 3. Build the `opentelemetry/opentelemetry-ruby` image | ||
| 3. Build the `opentelemetry/opentelemetry-ruby-contrib` image | ||
| * `docker-compose build` | ||
| * This makes the image available locally | ||
| 4. API: | ||
|
|
@@ -170,7 +168,7 @@ You'll need to create a Pull Request once you've finished your work. | |
| The [Kubernetes GitHub Workflow][kube-github-workflow-pr] document has | ||
| a significant section on PRs. | ||
|
|
||
| Open the PR against the `open-telemetry/opentelemetry-ruby` repository. | ||
| Open the PR against the `open-telemetry/opentelemetry-ruby-contrib` repository. | ||
|
|
||
| Please put `[WIP]` in the title, or create it as a [`Draft`][github-draft] PR | ||
| if the PR is not ready for review. | ||
|
|
@@ -249,7 +247,7 @@ Releases are normally performed using GitHub Actions. | |
| * For each gem, it will create a release tag and a GitHub release. | ||
| * It will build and push the gems to rubygems. | ||
| * It will build the docs and push them to | ||
| https://open-telemetry.github.io/opentelemetry-ruby | ||
| https://open-telemetry.github.io/opentelemetry-ruby-contrib | ||
| * If the releases succeed, the script will update the release pull | ||
| request with the results and change its label to `release: complete`. | ||
| If something went wrong, the script will, if possible, report the error | ||
|
|
@@ -306,7 +304,7 @@ release, you can use the `Force release` workflow. | |
|
|
||
| It is possible to run the release scripts locally if GitHub Actions is having | ||
| problems. You will need to install the `toys` gem first, and you will need the | ||
| Rubygems API key for opentelemetry-ruby. These commands will succeed only if | ||
| Rubygems API key for opentelemetry-ruby-contrib. These commands will succeed only if | ||
| you have write access to the repository. | ||
|
|
||
| To open a release pull request: | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.