Skip to content

CONTRIBUTING.md should contain API and SDK docker compose services. #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rscnt wants to merge 1 commit into from
Closed

CONTRIBUTING.md should contain API and SDK docker compose services. #344

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,16 +98,6 @@ To test using Docker:
3. Build the `opentelemetry/opentelemetry-ruby-contrib` image
* `docker-compose build`
* This makes the image available locally
4. API:
1. Install dependencies
* `docker-compose run api bundle install`
2. Run the tests
* `docker-compose run api bundle exec rake test`
5. SDK:
1. Install dependencies
* `docker-compose run sdk bundle install`
2. Run the tests for the sdk
* `docker-compose run sdk bundle exec rake test`

## Processing and visualizing traces locally

Expand Down