Skip to content

feat!: Separate logical MySQL host from connected host #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arielvalentin merged 8 commits into from
Jun 1, 2023
Merged

feat!: Separate logical MySQL host from connected host #487

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b6e760d
feat!: Separate logical MySQL host from connected
arielvalentin May 31, 2023
ad77dd5
Update instrumentation/trilogy/lib/opentelemetry/instrumentation/tril…
arielvalentin May 31, 2023
baef1f0
squash: use address suffix
arielvalentin Jun 1, 2023
e1ede30
squash: update tests
arielvalentin Jun 1, 2023
ff5a336
squash: fix syntax error
arielvalentin Jun 1, 2023
b2b4dd7
Merge branch 'main' into trilogy-db-cluster-name
arielvalentin Jun 1, 2023
8e4c5df
Merge branch 'main' into trilogy-db-cluster-name
arielvalentin Jun 1, 2023
ef54a50
Merge branch 'main' into trilogy-db-cluster-name
arielvalentin Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: fix syntax error
  • Loading branch information
@arielvalentin
arielvalentin authored Jun 1, 2023
commit ff5a336a0611aaea9a6da4c75714daaa067f20e6
4 changes: 2 additions & 2 deletions instrumentation/trilogy/test/opentelemetry/instrumentation/trilogy/instrumentation_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@
_(span.attributes[OpenTelemetry::SemanticConventions::Trace::DB_SYSTEM]).must_equal 'mysql'
_(span.attributes[OpenTelemetry::SemanticConventions::Trace::DB_STATEMENT]).must_equal 'SELECT ?'
_(span.attributes[OpenTelemetry::SemanticConventions::Trace::NET_PEER_NAME]).must_equal(host)
_(span.attributes[''db.mysql.instance.address']).must_be_nil
_(span.attributes['db.mysql.instance.address']).must_be_nil
end

it 'extracts statement type' do
Expand Down Expand Up @@ -172,7 +172,7 @@
_(span.attributes[OpenTelemetry::SemanticConventions::Trace::DB_SYSTEM]).must_equal 'mysql'
_(span.attributes[OpenTelemetry::SemanticConventions::Trace::DB_STATEMENT]).must_equal 'select @@hostname'
_(span.attributes[OpenTelemetry::SemanticConventions::Trace::NET_PEER_NAME]).must_equal(host)
_(span.attributes[''db.mysql.instance.address']).must_be_nil
_(span.attributes['db.mysql.instance.address']).must_be_nil

client.query('SELECT 1')

Expand Down