refactor: Remove Contrib Libraries #1319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes libraries that were relocated to the contrib package. Related: open-telemetry/opentelemetry-ruby-contrib#1 See open-telemetry/opentelemetry-ruby-contrib#3
arielvalentin
requested review from
ahayworth,
dazuma,
ericmustin,
fbogsany,
mwear,
plantfansam and
robertlaurin
as code owners
Minitest 5.16 has changes that cause mock verification to fail in our test suite. Reverting to an earlier version allows tests to pass. https://github.com/open-telemetry/opentelemetry-ruby/runs/6928651844?check_suite_focus=true
ahayworth
approved these changes
Jun 17, 2022
Contributor
ahayworth
left a comment
ahayworth
left a comment
There was a problem hiding this comment.
Joking aside, I did leave one comment on the README. But otherwise this looks good to me - and you win the award for most lines of code deleted in a PR!
README.md
Outdated
| - [Getting Started][getting-started] | ||
| - [Contributing](#contributing) | ||
| - [Instrumentation Libraries](#instrumentation-libraries) | ||
| - [Contrib Repository]](#contrib-repository) |
Contributor
There was a problem hiding this comment.
My only thought here is that it's nice to maintain something referring directly to "instrumentation libraries" both here in this link, and in the section below.
Basically I want to keep advertising loudly in big letters that we have a ton of instrumentation. If someone is quickly scanning the readme, I would want that fact to be very obvious. 😀
arielvalentin
commented
Jun 17, 2022
arielvalentin
commented
Jun 17, 2022
arielvalentin
commented
Jun 17, 2022
robertlaurin
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes libraries that were relocated to the contrib package.
Related: open-telemetry/opentelemetry-ruby-contrib#1
See open-telemetry/opentelemetry-ruby-contrib#3
💁🏼 Remove "Deleted files" from the filter to narrow down the changeset: