feat: Implement the Trace Response propagator #1397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ahayworth
reviewed
Nov 1, 2022
...mental/lib/opentelemetry/sdk/trace/propagation/trace_context/response_text_map_propagator.rb
Outdated
Show resolved
Hide resolved
plantfansam
reviewed
Nov 1, 2022
Contributor
plantfansam
left a comment
plantfansam
left a comment
There was a problem hiding this comment.
Looking good! I had a few questions/comments about the tests. I'd suggest adding a few test cases that push the edges: e.g. can we add assertions for what happens if span context is not valid?
...mental/lib/opentelemetry/sdk/trace/propagation/trace_context/response_text_map_propagator.rb
Outdated
Show resolved
Hide resolved
.../test/opentelemetry/sdk/trace/propagation/trace_context/response_text_map_propagator_test.rb
Outdated
Show resolved
Hide resolved
.../test/opentelemetry/sdk/trace/propagation/trace_context/response_text_map_propagator_test.rb
Outdated
Show resolved
Hide resolved
.../test/opentelemetry/sdk/trace/propagation/trace_context/response_text_map_propagator_test.rb
Outdated
Show resolved
Hide resolved
.../test/opentelemetry/sdk/trace/propagation/trace_context/response_text_map_propagator_test.rb
Outdated
Show resolved
Hide resolved
.../test/opentelemetry/sdk/trace/propagation/trace_context/response_text_map_propagator_test.rb
Outdated
Show resolved
Hide resolved
.../test/opentelemetry/sdk/trace/propagation/trace_context/response_text_map_propagator_test.rb
Outdated
Show resolved
Hide resolved
fbogsany
reviewed
Nov 1, 2022
...mental/lib/opentelemetry/sdk/trace/propagation/trace_context/response_text_map_propagator.rb
Outdated
Show resolved
Hide resolved
Adds a TextMapPropagator in the experimental SDK to inject `traceresponse` headers as defined in the [Trace Context][1] draft specification. [1]: https://w3c.github.io/trace-context/#traceresponse-header
wperron
force-pushed
the
trace-response-propagator
branch
from
84a7f25 to
bd6402f
Compare
wperron
requested review from
arielvalentin,
dazuma,
ericmustin,
mwear,
robbkidd and
robertlaurin
as code owners
wperron
requested review from
fbogsany and
plantfansam
and removed request for
fbogsany and
plantfansam
plantfansam
requested changes
Nov 3, 2022
...mental/lib/opentelemetry/sdk/trace/propagation/trace_context/response_text_map_propagator.rb
Outdated
Show resolved
Hide resolved
.../test/opentelemetry/sdk/trace/propagation/trace_context/response_text_map_propagator_test.rb
Outdated
Show resolved
Hide resolved
fbogsany
reviewed
Nov 4, 2022
fbogsany
reviewed
Nov 4, 2022
...mental/lib/opentelemetry/sdk/trace/propagation/trace_context/response_text_map_propagator.rb
Outdated
Show resolved
Hide resolved
…_context/response_text_map_propagator.rb Co-authored-by: Francis Bogsanyi <[email protected]>
fbogsany
approved these changes
Nov 8, 2022
robertlaurin
approved these changes
Nov 8, 2022
wperron
added a commit
to wperron/opentelemetry-ruby-contrib
that referenced
this pull request
Nov 9, 2022
Adds an optional config for the rack instrumentation to use the [new traceresponse propagator][1]. [1]: open-telemetry/opentelemetry-ruby#1397
wperron
added a commit
to wperron/opentelemetry-ruby-contrib
that referenced
this pull request
Nov 14, 2022
Adds an optional config for the rack instrumentation to use the [new traceresponse propagator][1]. [1]: open-telemetry/opentelemetry-ruby#1397
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a TextMapPropagator in the experimental SDK to inject
traceresponseheaders as defined in the Trace Context draft specification.Here is a gist demonstrating the propagator, based off of the existing http server example from this repo.