Skip to content

Expose ExemplarReservoir as configuration option of View. #3820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlosalberto merged 13 commits into from
Jan 31, 2024
Merged

Expose ExemplarReservoir as configuration option of View. #3820

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
61b590f
Add requirement to allow SDK users to provide their own ExemplarReser…
jsuereth Jan 12, 2024
500a25a
Updated compliance matrix for exemplars.
jsuereth Jan 12, 2024
7793ba7
Update changelog.
jsuereth Jan 12, 2024
32c43de
Regenerate TOC
jsuereth Jan 12, 2024
e35bba3
Make it clear exemplars are still feature freeze.
jsuereth Jan 16, 2024
2580724
Remove unecessary part of specification.
jsuereth Jan 16, 2024
792aa84
Fixes #3812 - ExemplarFilter does not need to be exposed as an interf…
jsuereth Jan 17, 2024
8bc8cf6
Regenerate toc.
jsuereth Jan 17, 2024
d881c52
Fix markdownlint.
jsuereth Jan 17, 2024
612034d
Add exemplar-filter to changelog.
jsuereth Jan 19, 2024
d7d4324
Fixes from review.
jsuereth Jan 19, 2024
1240e8a
Merge branch 'main' into wip-exemplar-in-view
jsuereth Jan 25, 2024
eb5096e
Merge branch 'main' into wip-exemplar-in-view
jsuereth Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make it clear exemplars are still feature freeze.
  • Loading branch information
@jsuereth
jsuereth committed Jan 17, 2024
commit e35bba3dcebe7e656f11fe70fb5f6c05fad4b9b7
9 changes: 5 additions & 4 deletions specification/metrics/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,10 +501,11 @@ meterProviderBuilder
);
```

In addition to `Aggregation`, the SDK MUST allow the optional configuring of
the [`ExemplarReservoir`](#exemplarreservoir) type when defining a view.
If no `ExemplarReservoir` is specified, then a default is chosen using
[Exemplar Default](#exemplar-defaults).
> **Status**: [Feature-freeze](../document-status.md) -
> In addition to `Aggregation`, the SDK MUST allow the optional configuring of
> the [`ExemplarReservoir`](#exemplarreservoir) type when defining a view.
> If no `ExemplarReservoir` is specified, then a default is chosen using
> [Exemplar Default](#exemplar-defaults).

The SDK MUST provide the following `Aggregation` to support the
[Metric Points](./data-model.md#metric-points) in the
Expand Down