Skip to content

Conversation

@chalin
Copy link
Contributor

@chalin chalin commented Jun 7, 2024

  • Contributes to Improved i18n support #4467
  • Adjusts htmltest ignore rules to be more inclusive of i18n pages, without having to name localization languages (well, as long as they are two letters for now :).
  • Normalizes links in en pages to make localization easier
  • Adjusts (improves) fallback config for ja and zh to be more inclusive

Preview: https://deploy-preview-4627--opentelemetry.netlify.app/ja/docs/

Followup:

  • Move images from under content/en/docs/demo/screenshots into static to ensure that they are shared(?)

@chalin chalin added the docs:i18n Internationalization and localization label Jun 7, 2024
@chalin chalin requested a review from a team June 7, 2024 21:37
@chalin chalin marked this pull request as draft June 7, 2024 21:56
@chalin chalin changed the title [i18n] Fallback to en for ja docs; en docs link normalization [i18n] Improved fallback configuration & en docs link normalization Jun 7, 2024
@chalin chalin changed the title [i18n] Improved fallback configuration & en docs link normalization [i18n] Improved fallback config, add ecosystem, and normalize en doc links Jun 7, 2024
@chalin chalin force-pushed the chalin-im-ja-docs-fallback-2024-06-07 branch from d8b618c to d20ece7 Compare June 7, 2024 22:23
@chalin chalin force-pushed the chalin-im-ja-docs-fallback-2024-06-07 branch from d20ece7 to 7009e9e Compare June 7, 2024 23:00
@chalin chalin changed the title [i18n] Improved fallback config, add ecosystem, and normalize en doc links [i18n] Improved fallback config and normalize en doc links Jun 7, 2024
@chalin chalin force-pushed the chalin-im-ja-docs-fallback-2024-06-07 branch from 7009e9e to ef224f7 Compare June 7, 2024 23:03
@chalin chalin added the docs:cleanup/refactoring Cleanup or refactor parts of the documentation label Jun 7, 2024
@chalin chalin marked this pull request as ready for review June 7, 2024 23:09
@chalin chalin requested review from a team and windsonsea June 7, 2024 23:09
@chalin chalin marked this pull request as draft June 8, 2024 00:03
@chalin
Copy link
Contributor Author

chalin commented Jun 8, 2024

Sigh, no this isn't ready. I got over ambitious with the fallback config by trying to cover as many sections as possible. Need to backtrack. Setting back to draft until then 🤷🏼‍♂️

@chalin chalin changed the title [i18n] Improved fallback config and normalize en doc links [i18n & ja] Improved fallback config and normalize en doc links Jun 8, 2024
@chalin chalin marked this pull request as ready for review June 8, 2024 08:59
@chalin
Copy link
Contributor Author

chalin commented Jun 8, 2024

This is ready for review once again.

@chalin chalin force-pushed the chalin-im-ja-docs-fallback-2024-06-07 branch from 5a1200b to 39e32ca Compare June 8, 2024 09:24
@chalin chalin force-pushed the chalin-im-ja-docs-fallback-2024-06-07 branch from 39e32ca to 2399142 Compare June 8, 2024 12:20
@chalin chalin merged commit e7a6289 into open-telemetry:main Jun 8, 2024
@chalin chalin deleted the chalin-im-ja-docs-fallback-2024-06-07 branch June 8, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs:cleanup/refactoring Cleanup or refactor parts of the documentation docs:i18n Internationalization and localization lang:ja sig:enduser

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants