Skip to content

Fix CHANGELOG.md (server.name does not exist) #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arminru merged 6 commits into from
Jun 22, 2023
Merged

Fix CHANGELOG.md (server.name does not exist) #126

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9711133
Fix CHANGELOG.md (server.name does not exist)
Oberon00 Jun 21, 2023
53acf50
Revert stray newline
Oberon00 Jun 21, 2023
e8c8012
Really fix stray newline
Oberon00 Jun 21, 2023
c4c9007
Fix accidental reversal/reduncancy
Oberon00 Jun 21, 2023
15ba2fd
Minimize
Oberon00 Jun 21, 2023
e0e5eb3
Merge branch 'main' into Oberon00-fix-changelog
Oberon00 Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix CHANGELOG.md (server.name does not exist)
  • Loading branch information
@Oberon00
Oberon00 authored Jun 21, 2023
commit 971113359be070e5dc426520c1a5c07103d3377d
4 changes: 2 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ release.
([#3402](https://github.com/open-telemetry/opentelemetry-specification/pull/3402))
BREAKING: rename `net.peer.name` to `server.address` on client side and to `client.address` on server side,
`net.peer.port` to `server.port` on client side and to `client.port` on server side,
`net.host.name` and `net.host.port` to `server.name` and `server.port` (since `net.host.*` attributes only applied to server instrumentation)
`net.host.name` and `net.host.port` to `server.address` and `server.port` on client side (`net.host.*` attributes do not apply to server instrumentation)
`net.sock.peer.addr` to `server.socket.address` on client side and to `client.socket.address` on server side,
`net.sock.peer.port` to `server.socket.port` on client side and to `client.socket.port` on server side,
`net.sock.peer.name` to `server.socket.domain` (since `net.sock.peer.name` only applied to client instrumentation),
Expand Down Expand Up @@ -94,4 +94,4 @@ release.
([#17](https://github.com/open-telemetry/opentelemetry-specification/pull/17))
- Mark service.version as stable.
([#106](https://github.com/open-telemetry/semantic-conventions/pull/106))