Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
fecc7ea
Added http route attribute to HTTP client attributes
klauco Jan 30, 2024
ac532b6
make table-generation
trask Jan 31, 2024
f3584ff
fixed comments
klauco Feb 1, 2024
148b46e
Updated brief
klauco Feb 7, 2024
0dd5aab
run table generation
klauco Feb 7, 2024
02ee3c2
changelog entry
klauco Feb 9, 2024
4c184a8
maybe -> may be
klauco Mar 7, 2024
d5c3a53
absolute path reference used, http spans with opt-in http.route
klauco Apr 7, 2024
8cbb7d2
using url.template on client spans and metrics
klauco Apr 30, 2024
384a230
updated brief
klauco Apr 30, 2024
d7f5183
Apply suggestions from code review
klauco May 1, 2024
4586315
marking semantic conventions for spans as stable unless otherwise spe…
klauco May 1, 2024
21c3d9d
toc updated
klauco May 1, 2024
14f1612
rebase and suggest span name
May 2, 2024
13cf2ea
clean up
May 2, 2024
7ec0443
change metrics to emphasize experimental status of url.template
May 2, 2024
17e7366
lint fix
klauco May 3, 2024
36913ad
Merge branch 'main' into allow-http-route-on-client
klauco May 3, 2024
2e18b03
Core review
May 6, 2024
03a5e66
span kind specification
klauco May 6, 2024
ed69c63
Merge branch 'main' into allow-http-route-on-client
klauco May 6, 2024
e76a144
Update docs/http/http-spans.md
May 7, 2024
549e633
Merge branch 'main' into allow-http-route-on-client
klauco May 7, 2024
b040abe
Merge branch 'main' into allow-http-route-on-client
klauco May 7, 2024
4f9deb9
Merge branch 'main' into allow-http-route-on-client
klauco May 7, 2024
540237d
Merge branch 'main' into allow-http-route-on-client
May 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
  • Loading branch information
2 people authored and Liudmila Molkova committed May 2, 2024
commit d7f51835a67a26bdc72dbb93c61c59e1bd905e13
1 change: 0 additions & 1 deletion model/http-common.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ groups:
requirement_level: opt_in
brief: >
The low-cardinality template of an [absolute path reference](https://www.rfc-editor.org/rfc/rfc3986#section-4.2) associated with outgoing HTTP request.
examples: ['/users/{id}', '/users?id={id}']
note: >
The `url.template` MUST have low cardinality. It is not usually available on HTTP clients, but may be known by the application or specialized HTTP instrumentation.

Expand Down
2 changes: 1 addition & 1 deletion model/registry/url.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ groups:
stability: experimental
brief: >
The low-cardinality template of an [absolute path reference](https://www.rfc-editor.org/rfc/rfc3986#section-4.2).
examples: ["/users/{id}", "/users?id={id}"]
examples: ["/users/{id}", "/users/:id", "/users?id={id}"]
- id: top_level_domain
type: string
stability: experimental
Expand Down