Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
MAY -> SHOULD
  • Loading branch information
trask committed Apr 26, 2024
commit 4f15fe632bc66423940d81769efe2938ef6a0ba8
2 changes: 1 addition & 1 deletion docs/attributes-registry/url.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Instrumentation SHOULD provide a configuration option to capture the full query
**[5]:** Sensitive content provided in `url.path` SHOULD be scrubbed when instrumentations can identify it.

**[6]:** Query string values SHOULD be redacted by default and replaced by the value `REDACTED`, e.g. `q=REDACTED&v=REDACTED` (the query string keys SHOULD be preserved).
Instrumentation MAY provide a configuration option to capture the full query string without any redaction.
Instrumentation SHOULD provide a configuration option to capture the full query string without any redaction.

**[7]:** This value can be determined precisely with the [public suffix list](http://publicsuffix.org). For example, the registered domain for `foo.example.com` is `example.com`. Trying to approximate this by simply taking the last two labels will not work well for TLDs such as `co.uk`.

Expand Down
2 changes: 1 addition & 1 deletion docs/http/http-spans.md
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ SHOULD include the [application root](/docs/http/http-spans.md#http-server-defin
**[9]:** See [Setting `server.address` and `server.port` attributes](/docs/http/http-spans.md#setting-serveraddress-and-serverport-attributes).

**[10]:** Query string values SHOULD be redacted by default and replaced by the value `REDACTED`, e.g. `q=REDACTED&v=REDACTED` (the query string keys SHOULD be preserved).
Instrumentation MAY provide a configuration option to capture the full query string without any redaction.
Instrumentation SHOULD provide a configuration option to capture the full query string without any redaction.

**[11]:** The IP address of the original client behind all proxies, if known (e.g. from [Forwarded#for](https://developer.mozilla.org/docs/Web/HTTP/Headers/Forwarded#for), [X-Forwarded-For](https://developer.mozilla.org/docs/Web/HTTP/Headers/X-Forwarded-For), or a similar header). Otherwise, the immediate client peer address.

Expand Down
2 changes: 1 addition & 1 deletion docs/url/url.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Instrumentation SHOULD provide a configuration option to capture the full query
**[2]:** Sensitive content provided in `url.path` SHOULD be scrubbed when instrumentations can identify it.

**[3]:** Query string values SHOULD be redacted by default and replaced by the value `REDACTED`, e.g. `q=REDACTED&v=REDACTED` (the query string keys SHOULD be preserved).
Instrumentation MAY provide a configuration option to capture the full query string without any redaction.
Instrumentation SHOULD provide a configuration option to capture the full query string without any redaction.
<!-- endsemconv -->

## Sensitive information
Expand Down
2 changes: 1 addition & 1 deletion model/registry/url.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ groups:
Query string values SHOULD be redacted by default and replaced by the value `REDACTED`, e.g.
`q=REDACTED&v=REDACTED` (the query string keys SHOULD be preserved).

Instrumentation MAY provide a configuration option to capture the full query string without any redaction.
Instrumentation SHOULD provide a configuration option to capture the full query string without any redaction.
- id: registered_domain
type: string
stability: experimental
Expand Down