-
Notifications
You must be signed in to change notification settings - Fork 294
Rename db.client.connections.* metrics to db.client.connection.* and rename db.client.connection.usage to db.client.connection.count and adapting units
#966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lmolkova
merged 17 commits into
open-telemetry:main
from
gregkalapos:RenameDbClientConnectionUsage
May 2, 2024
Merged
Changes from 8 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
33d2ef7
Rename `db.client.connections.usage` to `db.client.connections.count`
gregkalapos f4d76a6
Update database-metrics.md
gregkalapos fea988f
Update schema-next.yaml
gregkalapos 55850b5
Update database-metrics.yaml
gregkalapos d6701ed
Merge branch 'main' into RenameDbClientConnectionUsage
gregkalapos 8862118
Rename `db.client.connections.*` to `db.client.connection.*`
gregkalapos 6175103
Merge branch 'RenameDbClientConnectionUsage' of https://github.com/gr…
gregkalapos 0ebea0f
Update database.yaml
gregkalapos 495bbc4
Update db_client_connection_metric.yaml
gregkalapos 857c693
`connections` -> `connection`
gregkalapos 4e4a1af
Change unit in db.client.connections.* from `ms` to `s`
gregkalapos bc018a4
Update database.yaml
gregkalapos d6a39ba
Merge branch 'main' into RenameDbClientConnectionUsage
gregkalapos c14d22f
Update database.yaml
gregkalapos 82f9efc
Merge branch 'main' into RenameDbClientConnectionUsage
c9595aa
Update database.yaml
gregkalapos 52dddab
Merge branch 'main' into RenameDbClientConnectionUsage
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Use this changelog template to create an entry for release notes. | ||
| # | ||
| # If your change doesn't affect end users you should instead start | ||
| # your pull request title with [chore] or use the "Skip Changelog" label. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: breaking | ||
|
|
||
| # The name of the area of concern in the attributes-registry, (e.g. http, cloud, db) | ||
| component: db | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: > | ||
| Rename `db.client.connections.*` namespace to `db.client.connection.*` and | ||
| rename `db.client.connection.usage` to `db.client.connection.count`. | ||
|
|
||
| # Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
| # The values here must be integers. | ||
| issues: [201] | ||
|
|
||
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| groups: | ||
| - id: metric.deprecated.db.client.connections.count | ||
gregkalapos marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| type: metric | ||
| metric_name: db.client.connections.usage | ||
| stability: experimental | ||
| deprecated: "Replaced by `db.client.connection.count`." | ||
| brief: "Deprecated, use `db.client.connection.count` instead." | ||
| instrument: updowncounter | ||
| unit: "{connection}" | ||
| attributes: | ||
| - ref: db.client.connections.state | ||
| requirement_level: required | ||
| - ref: db.client.connections.pool.name | ||
| requirement_level: required | ||
|
|
||
| - id: metric.deprecated.db.client.connections.idle.max | ||
| type: metric | ||
| metric_name: db.client.connections.idle.max | ||
| stability: experimental | ||
| deprecated: "Replaced by `db.client.connection.idle.max`." | ||
| brief: "Deprecated, use `db.client.connection.idle.max` instead." | ||
| instrument: updowncounter | ||
| unit: "{connection}" | ||
| attributes: | ||
| - ref: db.client.connections.pool.name | ||
| requirement_level: required | ||
|
|
||
| - id: metric.deprecated.db.client.connections.idle.min | ||
| type: metric | ||
| metric_name: db.client.connections.idle.min | ||
| stability: experimental | ||
| deprecated: "Replaced by `db.client.connection.idle.min`." | ||
| brief: "Deprecated, use `db.client.connection.idle.min` instead." | ||
| instrument: updowncounter | ||
| unit: "{connection}" | ||
| attributes: | ||
| - ref: db.client.connections.pool.name | ||
| requirement_level: required | ||
|
|
||
| - id: metric.deprecated.db.client.connections.max | ||
| type: metric | ||
| metric_name: db.client.connections.max | ||
| stability: experimental | ||
| deprecated: "Replaced by `db.client.connection.max`." | ||
| brief: "Deprecated, use `db.client.connection.max` instead." | ||
| instrument: updowncounter | ||
| unit: "{connection}" | ||
| attributes: | ||
| - ref: db.client.connections.pool.name | ||
| requirement_level: required | ||
|
|
||
| - id: metric.deprecated.db.client.connections.pending_requests | ||
| type: metric | ||
| metric_name: db.client.connections.pending_requests | ||
| stability: experimental | ||
| deprecated: "Replaced by `db.client.connection.pending_requests`." | ||
| brief: "Deprecated, use `db.client.connection.pending_requests` instead." | ||
| instrument: updowncounter | ||
| unit: "{request}" | ||
| attributes: | ||
| - ref: db.client.connections.pool.name | ||
| requirement_level: required | ||
|
|
||
| - id: metric.deprecated.db.client.connections.timeouts | ||
| type: metric | ||
| metric_name: db.client.connections.timeouts | ||
| stability: experimental | ||
| deprecated: "Replaced by `db.client.connection.timeouts`." | ||
| brief: "Deprecated, use `db.client.connection.timeouts` instead." | ||
| instrument: counter | ||
| unit: "{timeout}" | ||
| attributes: | ||
| - ref: db.client.connections.pool.name | ||
| requirement_level: required | ||
|
|
||
| - id: metric.deprecated.db.client.connections.create_time | ||
| type: metric | ||
| metric_name: db.client.connections.create_time | ||
| stability: experimental | ||
| deprecated: "Replaced by `db.client.connection.create_time`." | ||
| brief: "Deprecated, use `db.client.connection.create_time` instead." | ||
| instrument: histogram | ||
| unit: "ms" | ||
| attributes: | ||
| - ref: db.client.connections.pool.name | ||
| requirement_level: required | ||
|
|
||
| - id: metric.deprecated.db.client.connections.wait_time | ||
| type: metric | ||
| metric_name: db.client.connections.wait_time | ||
| stability: experimental | ||
| deprecated: "Replaced by `db.client.connection.wait_time`." | ||
| brief: "Deprecated, use `db.client.connection.wait_time` instead." | ||
| instrument: histogram | ||
| unit: "ms" | ||
| attributes: | ||
| - ref: db.client.connections.pool.name | ||
| requirement_level: required | ||
|
|
||
| - id: metric.deprecated.db.client.connections.use_time | ||
| type: metric | ||
| metric_name: db.client.connections.use_time | ||
| stability: experimental | ||
| deprecated: "Replaced by `db.client.connection.use_time`." | ||
| brief: "Deprecated, use `db.client.connection.use_time` instead." | ||
lmolkova marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| instrument: histogram | ||
| unit: "ms" | ||
| attributes: | ||
| - ref: db.client.connections.pool.name | ||
| requirement_level: required | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.