Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
review and lint
  • Loading branch information
Liudmila Molkova committed Apr 30, 2024
commit b83d632f148926bc7c7934b0d2edbfbcba1f53b1
7 changes: 7 additions & 0 deletions .chloggen/974.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
change_type: breaking

component: db

note: Clarify database span name format and fallback values.

issues: [974, 704]
3 changes: 2 additions & 1 deletion docs/database/database-spans.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ linkTitle: Client Calls

<!-- toc -->

- [Name](#name)
- [Common attributes](#common-attributes)
- [Notes and well-known identifiers for `db.system`](#notes-and-well-known-identifiers-for-dbsystem)
- [Semantic Conventions for specific database technologies](#semantic-conventions-for-specific-database-technologies)
Expand Down Expand Up @@ -73,9 +74,9 @@ The <span id="target-placeholder">`{target}`</span> SHOULD adhere to one of the
- `db.collection.name`
- `db.namespace`
- `server.address:server.port`
- `network.peer.address:network.peer.port`
- `db.system`


## Common attributes

These attributes will usually be the same for all operations performed over the same database connection.
Expand Down
2 changes: 1 addition & 1 deletion docs/database/elasticsearch.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ Tracing instrumentations that do so, MUST also set `http.request.method_original

| Key | Value |
|:------------------------------------|:------------------------------------------------------------------------------------------------------------------------------------|
| Span name | `"search elasticsearch.mydomain.com:9200"` |
| Span name | `"search"` |
| `db.system` | `"elasticsearch"` |
| `server.address` | `"elasticsearch.mydomain.com"` |
| `server.port` | `9200` |
Expand Down