Skip to content

Limit Call size to 200 bytes #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xlc merged 13 commits into from
Sep 2, 2021
Merged

Limit Call size to 200 bytes #598

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
07d5b93
xtokens reduce Call size
ferrell-code Sep 1, 2021
d388f59
fmt
ferrell-code Sep 1, 2021
819f313
limit to 200
ferrell-code Sep 1, 2021
6f5da03
xcm and authority
ferrell-code Sep 2, 2021
36248a0
fmt
ferrell-code Sep 2, 2021
ca45617
add sp_std Box
ferrell-code Sep 2, 2021
f981733
xtoken tests
ferrell-code Sep 2, 2021
4613a9a
add xcm size limit test
ferrell-code Sep 2, 2021
1832f55
authority
ferrell-code Sep 2, 2021
951cb9b
Revert "add xcm size limit test"
ferrell-code Sep 2, 2021
4e1d4ef
Revert "Revert "add xcm size limit test""
ferrell-code Sep 2, 2021
e555cd6
Revert "authority"
ferrell-code Sep 2, 2021
33bc599
authority lower call size
ferrell-code Sep 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
authority
  • Loading branch information
@ferrell-code
ferrell-code committed Sep 2, 2021
commit 1832f5515cffa15b0a782907934dca3a325ec9ce
6 changes: 5 additions & 1 deletion authority/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,11 @@ pub mod module {
let info = call.get_dispatch_info();
(T::WeightInfo::dispatch_as().saturating_add(info.weight), info.class)
})]
pub fn dispatch_as(origin: OriginFor<T>, as_origin: T::AsOriginId, call: Box<CallOf<T>>) -> DispatchResult {
pub fn dispatch_as(
origin: OriginFor<T>,
as_origin: Box<T::AsOriginId>,
call: Box<CallOf<T>>,
) -> DispatchResult {
as_origin.check_dispatch_from(origin)?;

let e = call.dispatch(as_origin.into_origin().into());
Expand Down
20 changes: 10 additions & 10 deletions authority/src/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,31 +21,31 @@ fn dispatch_as_work() {
let ensure_signed_call = Call::System(frame_system::Call::remark(vec![]));
assert_ok!(Authority::dispatch_as(
Origin::root(),
MockAsOriginId::Root,
Box::new(MockAsOriginId::Root),
Box::new(ensure_root_call)
));
assert_ok!(Authority::dispatch_as(
Origin::root(),
MockAsOriginId::Account1,
Box::new(MockAsOriginId::Account1),
Box::new(ensure_signed_call.clone())
));
assert_noop!(
Authority::dispatch_as(
Origin::signed(1),
MockAsOriginId::Root,
Box::new(MockAsOriginId::Root),
Box::new(ensure_signed_call.clone())
),
BadOrigin,
);
assert_ok!(Authority::dispatch_as(
Origin::signed(1),
MockAsOriginId::Account1,
Box::new(MockAsOriginId::Account1),
Box::new(ensure_signed_call.clone())
));
assert_noop!(
Authority::dispatch_as(
Origin::signed(1),
MockAsOriginId::Account2,
Box::new(MockAsOriginId::Account2),
Box::new(ensure_signed_call)
),
BadOrigin,
Expand All @@ -58,7 +58,7 @@ fn schedule_dispatch_at_work() {
ExtBuilder::default().build().execute_with(|| {
let ensure_root_call = Call::System(frame_system::Call::fill_block(Perbill::one()));
let call = Call::Authority(authority::Call::dispatch_as(
MockAsOriginId::Root,
Box::new(MockAsOriginId::Root),
Box::new(ensure_root_call),
));
run_to_block(1);
Expand Down Expand Up @@ -116,7 +116,7 @@ fn schedule_dispatch_after_work() {
ExtBuilder::default().build().execute_with(|| {
let ensure_root_call = Call::System(frame_system::Call::fill_block(Perbill::one()));
let call = Call::Authority(authority::Call::dispatch_as(
MockAsOriginId::Root,
Box::new(MockAsOriginId::Root),
Box::new(ensure_root_call),
));
run_to_block(1);
Expand Down Expand Up @@ -175,7 +175,7 @@ fn fast_track_scheduled_dispatch_work() {
System::set_block_number(1);
let ensure_root_call = Call::System(frame_system::Call::fill_block(Perbill::one()));
let call = Call::Authority(authority::Call::dispatch_as(
MockAsOriginId::Root,
Box::new(MockAsOriginId::Root),
Box::new(ensure_root_call),
));
run_to_block(1);
Expand Down Expand Up @@ -252,7 +252,7 @@ fn delay_scheduled_dispatch_work() {
System::set_block_number(1);
let ensure_root_call = Call::System(frame_system::Call::fill_block(Perbill::one()));
let call = Call::Authority(authority::Call::dispatch_as(
MockAsOriginId::Root,
Box::new(MockAsOriginId::Root),
Box::new(ensure_root_call),
));
run_to_block(1);
Expand Down Expand Up @@ -328,7 +328,7 @@ fn cancel_scheduled_dispatch_work() {
ExtBuilder::default().build().execute_with(|| {
let ensure_root_call = Call::System(frame_system::Call::fill_block(Perbill::one()));
let call = Call::Authority(authority::Call::dispatch_as(
MockAsOriginId::Root,
Box::new(MockAsOriginId::Root),
Box::new(ensure_root_call),
));
run_to_block(1);
Expand Down