fix: introduce codex-protocol crate #2355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpeal
approved these changes
Aug 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new crate in the workspace,
codex-protocol, which is initially seeded withcore/src/protocol.rsand its dependencies. See the newprotocol/README.mdfor details.Note this is the first step in bringing the existing
core/src/protocol.rsandmcp-server/src/wire_format.rscloser together so that we have one place where we define "types."Admittedly, over time, it is more important to commit to a contract for types exposed by
codex mcp, but today, there is a number of cases where we convert between "MCP types" and internal types, and it isn't often meaningful, so it would be nice to share more types directly.