Fix esc #2661
Fix esc #2661
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| popup.move_down(); | ||
| (InputResult::None, true) | ||
| } | ||
| KeyEvent { | ||
| code: KeyCode::Esc, .. | ||
| } => { | ||
| // Dismiss the slash popup; keep the current input untouched. | ||
| self.active_popup = ActivePopup::None; | ||
| (InputResult::None, true) |
There was a problem hiding this comment.
[P1] Esc dismissal of slash popup reopened immediately
In handle_key_event_with_slash_popup the Esc branch clears active_popup (lines 321‑327) to hide the slash command menu. But handle_key_event then unconditionally calls sync_command_popup (lines 280‑290), which recreates the popup whenever the text still starts with '/'. Thus Esc cannot actually close the popup, contradicting the intended behaviour.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Do we want to esc hide pop up on the slash or not?
@edward-bayes @easong-openai
There was a problem hiding this comment.
Ideally yes - sometimes you just want a /
Esc should have other functionalities when it's not used in a backtracking situation. i.e. to cancel pop up menu when selecting model/approvals or to interrupt an active turn.