fix(tui): separate stream-error logs from user message in edit prefill #2757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: Fundamentally, the logic that treats a "user" text line as a user-message marker—and the heuristic that uses blank lines as boundaries—needs to be revisited. In the current design, if a Codex response happens to include a line that is exactly "user", it can be misclassified as a user message. Rather than relying on raw text parsing, we should refactor to persist and use cell-level metadata (e.g., role/type) for message identification. |
|
100% agreeing with your last message |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2755
Before
2025-08-27.4.23.53.mov
After
2025-08-27.4.24.58.mov
Solution
Add a leading blank line to the stream-error history cell (
new_stream_error_event, likenew_error_event) so it renders as an independent block.