disallow some slash commands while a task is running #2792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| | SlashCommand::Status | ||
| | SlashCommand::Mcp | ||
| | SlashCommand::Quit | ||
| | SlashCommand::TestApproval => true, |
There was a problem hiding this comment.
Why do we have a test approval even?
There was a problem hiding this comment.
it's for testing the approval dialogs, it's a debug-only command. easy way to make an approval dialog appear on the screen.
There was a problem hiding this comment.
I think we should remove it or render it only on Openai accounts but that's for later.
There was a problem hiding this comment.
@aibrahim-oai it's already only rendered if you build in debug mode, release mode doesn't have it.
aibrahim-oai
approved these changes
Aug 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/new, /init, /models, /approvals, etc. don't work correctly during a turn. disable them.