Include apply_patch tool for oss models from gpt-oss providers with different naming convention (e.g. openai/gpt-oss-*)
#2811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
andrewtlw
force-pushed
the
oss-model-family-slug-matching
branch
from
fac5f52 to
119ed46
Compare
|
hey @dylan-hurd-oai @bolinfest - would love to get any feedback on this, thanks! |
dylan-hurd-oai
approved these changes
Sep 8, 2025
…ere gpt-oss model names from different providers have a prefix like openai/gpt-oss/120b
andrewtlw
force-pushed
the
oss-model-family-slug-matching
branch
from
f9c0190 to
d3d010b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model providers like Groq, Openrouter, AWS Bedrock, VertexAI and others typically prefix the name of gpt-oss models with
openai, e.g.openai/gpt-oss-120b.This PR is to match the model name slug using
containsinstead ofstarts_withto ensure that theapply_patchtool is included in the tools for models names likeopenai/gpt-oss-120bWithout this, the gpt-oss models will often try to call the
apply_patchtool directly instead of via theshellcommand, leading to validation errors.I have run all the local checks.
Note: The gpt-oss models from non-Ollama providers are typically run via a profile with a different base_url (instead of with the
--ossflag)