Following up on #2371 post commit feedback #2852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easong-openai
approved these changes
Aug 29, 2025
bolinfest
approved these changes
Aug 29, 2025
| @@ -95,7 +95,6 @@ pub enum ResponseEvent { | |||
| ReasoningSummaryPartAdded, | |||
| WebSearchCallBegin { | |||
| call_id: String, | |||
| query: Option<String>, | |||
There was a problem hiding this comment.
Should we keep this around? Might the UI want this?
| @@ -2048,6 +2049,17 @@ async fn handle_response_item( | |||
| debug!("unexpected CustomToolCallOutput from stream"); | |||
| None | |||
| } | |||
| ResponseItem::WebSearchCall { id, action, .. } => { | |||
| if let WebSearchAction::Search { query } = action { | |||
| let call_id = id.unwrap_or_else(|| "".to_string()); | |||
There was a problem hiding this comment.
Is this OK or a logical error? Can we make this a stronger check?
| // } | ||
| WebSearchCall { | ||
| #[serde(default, skip_serializing_if = "Option::is_none")] | ||
| id: Option<String>, |
There was a problem hiding this comment.
So this is not reliably supplied?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.