Skip to content

Conversation

aibrahim-oai
Copy link
Collaborator

@aibrahim-oai aibrahim-oai commented Aug 28, 2025

  • Introduce websearch end to complement the begin
  • Moves the logic of adding the sebsearch tool to create_tools_json_for_responses_api
  • Making it the client responsibility to toggle the tool on or off
  • Other misc in Add web search tool #2371 post commit feedback
  • Show the query:
image

@aibrahim-oai aibrahim-oai requested a review from bolinfest August 28, 2025 22:02
@@ -95,7 +95,6 @@ pub enum ResponseEvent {
ReasoningSummaryPartAdded,
WebSearchCallBegin {
call_id: String,
query: Option<String>,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep this around? Might the UI want this?

@@ -2048,6 +2049,17 @@ async fn handle_response_item(
debug!("unexpected CustomToolCallOutput from stream");
None
}
ResponseItem::WebSearchCall { id, action, .. } => {
if let WebSearchAction::Search { query } = action {
let call_id = id.unwrap_or_else(|| "".to_string());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this OK or a logical error? Can we make this a stronger check?

// }
WebSearchCall {
#[serde(default, skip_serializing_if = "Option::is_none")]
id: Option<String>,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is not reliably supplied?

@bolinfest bolinfest merged commit 9dbe728 into main Aug 29, 2025
25 of 27 checks passed
@bolinfest bolinfest deleted the post-search-feedback branch August 29, 2025 02:24
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants