fix: specify --profile to cargo clippy in CI
#2871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibrahim-oai
approved these changes
Aug 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we had a breakage in the release build that went unnoticed by CI. Here is what happened:
cargo testfor release builds on ordinary CI because it is slow, particularly with --all-features set #2276 undid that change to try to speed things up by removing the step to build all the individual crates in release mode, assuming thecargo checkcall was sufficient coverage, which it would have been, had it specified--profileThis PR adds
--profileto thecargo checkstep so we should get the desired coverage from our build matrix.Indeed, enabling this in our CI uncovered a warning that is only present in release mode that was going unnoticed.