tui: fix laggy typing #2922
Merged
tui: fix laggy typing #2922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -223,7 +224,7 @@ impl ChatComposer { | |||
| let placeholder = format!("[Pasted Content {char_count} chars]"); | |||
| self.textarea.insert_element(&placeholder); | |||
| self.pending_pastes.push((placeholder, pasted)); | |||
| } else if self.handle_paste_image_path(pasted.clone()) { | |||
| } else if char_count > 1 && self.handle_paste_image_path(pasted.clone()) { | |||
There was a problem hiding this comment.
We could probably make this tighter too -- at minimum every image file would have .png .jpg so >4 characters.
There was a problem hiding this comment.
ehh, technically that's not required of an image file; they could have any or no extension. bit of an edge case, and especially unlikely for pasted paths as i think almost always the pasted path will be an absolute path, but this is the simplest thing we can do that's almost-always correct. (technically i suppose someone could paste a single-character path that's an image...)
aibrahim-oai
approved these changes
Sep 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we were checking every typed character to see if it was an image. this involved going to disk, which was slow.
this was a bad interaction between image paste support and burst-paste detection.