MCP: add session resume + history listing; #3185
Conversation
|
@codex review this in detail. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| pub num_scanned_files: usize, | ||
| pub reached_scan_cap: bool, |
There was a problem hiding this comment.
Why return num_scanned_files?
How about just has_more: bool?
There was a problem hiding this comment.
next_cursor should be non if it doesn't have more.
num_scanned_files and reached_scan_cap are admittedly extra information that the clients wouldn't probably need.
External (non-OpenAI) Pull Request Requirements
Before opening this Pull Request, please read the dedicated "Contributing" markdown file or your PR may be closed:
https://github.com/openai/codex/blob/main/docs/contributing.md
If your PR conforms to our contribution guidelines, replace this text with a detailed and high quality description of your changes.