chore: upgrade to actions/setup-node@v5 #3316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolinfest
requested review from
pakrym-oai,
aibrahim-oai,
dylan-hurd-oai and
gpeal
gpeal
approved these changes
Sep 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot tried to automatically upgrade us to
actions/setup-node@v5in #3293, but it broke our CI. Note this upgrade has breaking changes:https://github.com/actions/setup-node/releases/tag/v5.0.0
I think the problem was that
v5was correctly reading ourpackageManagerline here:codex/package.json
Line 24 in e2b3053
and then tried to run
pnpm, but couldn't because it wasn't available yet. This PR:pnpm/action-setupbeforeactions/setup-nodeversionfrom ourpnpm/action-setupstep because it is not necessary when it is specified inpackage.json(which it is in our case), so leaving it here ran the risk of the two getting out of syncactions/setup-nodefromv4tov5v5claims to do this for us now--frozen-lockfileto ourpnpm installinvocation, which seemed like something we should have always had there