Skip to content

Conversation

dedrisian-oai
Copy link
Collaborator

@dedrisian-oai dedrisian-oai commented Sep 14, 2025

There are exactly 4 types of flaky tests in Windows x86 right now:

  1. review_input_isolated_from_parent_history => Times out waiting for closing events
  2. review_does_not_emit_agent_message_on_structured_output => Times out waiting for closing events
  3. auto_compact_runs_after_token_limit_hit => Times out waiting for closing events
  4. auto_compact_runs_after_token_limit_hit => Also has a problem where auto compact should add a third request, but receives 4 requests.

1, 2, and 3 seem to be solved with increasing threads on windows runner from 2 -> 4.

Don't know yet why # 4 is happening, but probably also because of WireMock issues on windows causing races.

@dedrisian-oai dedrisian-oai force-pushed the daniel/attempt-fix-flaky-window-test-review branch from cf2c4ab to c5ad3cb Compare September 14, 2025 21:57
@dedrisian-oai dedrisian-oai changed the title Attempt to fix flaky windows test Fix flaky windows test Sep 14, 2025
@dedrisian-oai
Copy link
Collaborator Author

@bolinfest Lmk if it looks good, I'll revert the CI script changes before merging.

@dedrisian-oai dedrisian-oai enabled auto-merge (squash) September 14, 2025 23:12
@dedrisian-oai dedrisian-oai merged commit b2f6fc3 into main Sep 14, 2025
19 checks passed
@dedrisian-oai dedrisian-oai deleted the daniel/attempt-fix-flaky-window-test-review branch September 14, 2025 23:20
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants