Add session header to chat widget #3592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibrahim-oai
force-pushed
the
codex/update-header-to-display-model-version-directory
branch
from
da1ed96 to
f49a42d
Compare
bolinfest
requested changes
Sep 14, 2025
codex-rs/tui/src/chatwidget.rs
Outdated
| @@ -1278,7 +1302,11 @@ impl ChatWidget { | |||
|
|
|||
| /// Set the model in the widget's config copy. | |||
| pub(crate) fn set_model(&mut self, model: String) { | |||
| let header_changed = self.session_header.set_model(model.clone()); | |||
There was a problem hiding this comment.
I would change model to be &str instead of String and avoid clone() when it's not really necessary.
| Self { model } | ||
| } | ||
|
|
||
| pub(crate) fn set_model(&mut self, model: String) -> bool { |
There was a problem hiding this comment.
Please document the return type.
| } | ||
|
|
||
| impl SessionHeader { | ||
| // Keep signature to avoid changing call sites; underscore params silence warnings. |
There was a problem hiding this comment.
Isn't this new in this PR? Why are these being passed in?
tibo-openai
deleted the
codex/update-header-to-display-model-version-directory
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.