Skip to content

Conversation

aibrahim-oai
Copy link
Collaborator

Reverts #3538
It panics on forking first message. It also calculates the index in a wrong way.

@aibrahim-oai aibrahim-oai enabled auto-merge (squash) September 15, 2025 03:05
Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment on lines +74 to +78
.spans
.iter()
.all(|s| s.content.as_ref().trim().is_empty());
if is_blank {
break;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Preserve blank lines in backtrack prefill

The helper used to recover the Nth last user message breaks out of the loop at the first empty Line after the "user" header. If the original message contained blank lines (multi‑paragraph inputs), everything after the first empty line is discarded both when highlighting the selection and when pre‑filling the composer during backtracking, so the user edits only part of their message. The extraction should treat blank lines inside a message as part of the message and stop only when the next message block begins (e.g., when the next header is encountered) or by reusing the original UserHistoryCell content.

Useful? React with 👍 / 👎.

@aibrahim-oai aibrahim-oai merged commit 26f1246 into main Sep 15, 2025
19 checks passed
@aibrahim-oai aibrahim-oai deleted the revert-3538-nornagon/transcript-cells branch September 15, 2025 03:39
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants