Login flow polish #3632
Merged
Login flow polish #3632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tibo-openai
approved these changes
Sep 15, 2025
bolinfest
reviewed
Sep 15, 2025
|
|
||
| let frames = &FRAMES_DEFAULT; | ||
| let idx = if FRAME_TICK.as_millis() > 0 { | ||
| let steps = |
There was a problem hiding this comment.
I don't believe this is guaranteed to render the frames in order?
There was a problem hiding this comment.
I think this is trying to maintain a consistent mapping of frames / time elapsed, but it is possible that frames get dropped. Maybe that's OK?
bolinfest
reviewed
Sep 15, 2025
| self.request_frame.schedule_frame_in(FRAME_TICK); | ||
|
|
||
| let frames = &FRAMES_DEFAULT; | ||
| let idx = if FRAME_TICK.as_millis() > 0 { |
There was a problem hiding this comment.
This if FRAME_TICK.as_millis() > 0 is always true, but somewhat understandable why it's there...
|
I did 
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tests