fix stray login url characters persisting in login #3639
Conversation
|
@codex do a review |
|
Codex Review: Didn't find any major issues. Bravo. About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback". |
| if !did_full_clear_after_success | ||
| && onboarding_screen.steps.iter().any(|step| { | ||
| if let Step::Auth(w) = step { | ||
| let g = w.sign_in_state.read().unwrap(); |
There was a problem hiding this comment.
This use of unwrap() is the source of the clippy failure?
Though strangely it seems like other uses of unwrap() in this file are accepted?
| && onboarding_screen.steps.iter().any(|step| { | ||
| if let Step::Auth(w) = step { | ||
| w.sign_in_state.read().is_ok_and(|g| { | ||
| matches!(&*g, super::auth::SignInState::ChatGptSuccessMessage) | ||
| }) | ||
| } else { | ||
| false | ||
| } | ||
| }) |
There was a problem hiding this comment.
So we iterate over onboarding_screen.steps and take the read lock of the mutex each time...should we just take the read lock and then iterate over onboarding_screen.steps?
|
@easong-openai I pushed a change to update your PR to fix the clippy issue. Please take a look. |
Fixes this.