restyle thinking outputs #3755
Merged
restyle thinking outputs #3755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
nornagon-openai
commented
Sep 16, 2025
nornagon-openai
commented
codex-rs/tui/src/history_cell.rs
Outdated
| let lines = cells[1].display_lines(80); | ||
| assert_eq!( | ||
| lines, | ||
| vec![vec!["> ".into(), "Detailed reasoning goes here.".dim().italic()].into()] |
There was a problem hiding this comment.
Maybe we could use a different character to ">" here to create separation between thinking and assistant message? Perhaps a bullet like the other tools or an empty bullet i.e. "○"
There was a problem hiding this comment.
switched to •.
edward-bayes
approved these changes
Sep 16, 2025
apanasenko-oai
approved these changes
Sep 16, 2025
| ) | ||
| } | ||
|
|
||
| fn transcript_lines(&self) -> Vec<Line<'static>> { |
There was a problem hiding this comment.
do we want to push header in transcript?
There was a problem hiding this comment.
i left it off because we don't show it in the main view... let's try it without and see how we feel.
There was a problem hiding this comment.
we show them in bottom panel (e.g. header/shimmer).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.