chore: use tokio mutex and async function to prevent blocking a worker #3850
+96
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bolinfest
approved these changes
Sep 18, 2025
| @@ -3356,7 +3366,7 @@ mod tests { | |||
| }), | |||
| )); | |||
|
|
|||
| let actual = session.state.lock_unchecked().history.contents(); | |||
| let actual = tokio_test::block_on(async { session.state.lock().await.history.contents() }); | |||
There was a problem hiding this comment.
Should we be switching to tokio::test instead for these?
There was a problem hiding this comment.
Will switch all the tests in a dedicated PR. Let's keep them small for now :)
There was a problem hiding this comment.
Sounds great: I <3 small, specific PRs!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why Use
tokio::sync::Mutexstd::sync::Mutexare not async-aware. As a result, they will block the entire thread instead of just yielding the task. Furthermore they can be poisoned which is not the case oftokioMutex.This allows the Tokio runtime to continue running other tasks while waiting for the lock, preventing deadlocks and performance bottlenecks.
In general, this is preferred in async environment