Skip to content

Return shared ArrayPool #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsquire merged 5 commits into from
Jun 23, 2025
Merged

Return shared ArrayPool #459

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
95d3dce
Update OpenAIEmbedding.cs
shargon Jun 18, 2025
a5325a7
Update AsyncWebsocketMessageEnumerator.cs
shargon Jun 18, 2025
a864ffa
Update RealtimeConversationSession.cs
shargon Jun 18, 2025
22c0999
Update ConversationTests.cs
shargon Jun 18, 2025
16281ae
Move to finally
shargon Jun 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update RealtimeConversationSession.cs
  • Loading branch information
@shargon
shargon authored Jun 18, 2025
commit a864ffafba2f8a956a62d0a64d58a5b8f640095f
8 changes: 5 additions & 3 deletions src/Custom/RealtimeConversation/RealtimeConversationSession.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,9 @@ public virtual async Task SendInputAudioAsync(Stream audio, CancellationToken ca
}
_isSendingAudioStream = true;
}
byte[] buffer = ArrayPool<byte>.Shared.Rent(1024 * 16);
try
{
byte[] buffer = ArrayPool<byte>.Shared.Rent(1024 * 16);
while (true)
{
int bytesRead = await audio.ReadAsync(buffer, 0, buffer.Length, cancellationToken).ConfigureAwait(false);
Expand All @@ -75,6 +75,7 @@ public virtual async Task SendInputAudioAsync(Stream audio, CancellationToken ca
}
finally
{
ArrayPool<byte>.Shared.Return(buffer);
using (await _audioSendSemaphore.AutoReleaseWaitAsync(cancellationToken).ConfigureAwait(false))
{
_isSendingAudioStream = false;
Expand All @@ -93,9 +94,9 @@ public virtual void SendInputAudio(Stream audio, CancellationToken cancellationT
}
_isSendingAudioStream = true;
}
byte[] buffer = ArrayPool<byte>.Shared.Rent(1024 * 16);
try
{
byte[] buffer = ArrayPool<byte>.Shared.Rent(1024 * 16);
while (true)
{
int bytesRead = audio.Read(buffer, 0, buffer.Length);
Expand All @@ -113,6 +114,7 @@ public virtual void SendInputAudio(Stream audio, CancellationToken cancellationT
}
finally
{
ArrayPool<byte>.Shared.Return(buffer);
using (_audioSendSemaphore.AutoReleaseWait(cancellationToken))
{
_isSendingAudioStream = false;
Expand Down Expand Up @@ -349,4 +351,4 @@ public void Dispose()
{
WebSocket?.Dispose();
}
}
}