Skip to content

Improve disposal logic in AsyncWebsocketMessageResultEnumerator to prevent multiple disposals #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KrzysztofCwalina merged 3 commits into from
Jun 24, 2025
Merged

Improve disposal logic in AsyncWebsocketMessageResultEnumerator to prevent multiple disposals #476

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e061c35
Improve disposal logic in AsyncWebsocketMessageResultEnumerator to pr…
christothes Jun 23, 2025
1cf836b
fb
christothes Jun 24, 2025
6699f39
Update src/Custom/RealtimeConversation/Internal/AsyncWebsocketMessage…
christothes Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update src/Custom/RealtimeConversation/Internal/AsyncWebsocketMessage… 
…Enumerator.cs

Co-authored-by: Stephen Toub <[email protected]>
  • Loading branch information
@christothes @stephentoub
christothes and stephentoub authored Jun 24, 2025
commit 6699f3997b32f16c818291f8c5336a0fb7c7ab4e
2 changes: 1 addition & 1 deletion src/Custom/RealtimeConversation/Internal/AsyncWebsocketMessageEnumerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public ValueTask DisposeAsync()
ArrayPool<byte>.Shared.Return(toReturn);
}
_webSocket?.Dispose();
return new ValueTask(Task.CompletedTask);
return default;
}

public async ValueTask<bool> MoveNextAsync()
Expand Down