Skip to content

fix: runTools without stream should not emit user message events #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2024
Merged

fix: runTools without stream should not emit user message events #1005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: runTools without stream should not emit user message events
  • Loading branch information
@yjp20
yjp20 committed Aug 20, 2024
commit 29b8ee558de463e64060a55165fb0b64f05a7022
8 changes: 6 additions & 2 deletions src/lib/ChatCompletionRunner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,12 @@ export class ChatCompletionRunner<ParsedT = null> extends AbstractChatCompletion
return runner;
}

override _addMessage(this: ChatCompletionRunner<ParsedT>, message: ChatCompletionMessageParam) {
super._addMessage(message);
override _addMessage(
this: ChatCompletionRunner<ParsedT>,
message: ChatCompletionMessageParam,
emit: boolean = true,
) {
super._addMessage(message, emit);
if (isAssistantMessage(message) && message.content) {
this._emit('content', message.content as string);
}
Expand Down
12 changes: 0 additions & 12 deletions tests/lib/ChatCompletionRunFunctions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,6 @@ describe('resource completions', () => {
await runner.done();

expect(listener.messages).toEqual([
{ role: 'user', content: 'tell me what the weather is like' },
{
role: 'assistant',
content: null,
Expand Down Expand Up @@ -700,7 +699,6 @@ describe('resource completions', () => {
await runner.done().catch(() => {});

expect(listener.messages).toEqual([
{ role: 'user', content: 'tell me what the weather is like' },
{
role: 'assistant',
content: null,
Expand Down Expand Up @@ -855,10 +853,6 @@ describe('resource completions', () => {
await runner.done();

expect(listener.messages).toEqual([
{
role: 'user',
content: 'can you tell me how many properties are in {"a": 1, "b": 2, "c": 3}',
},
{
role: 'assistant',
content: null,
Expand Down Expand Up @@ -1090,10 +1084,6 @@ describe('resource completions', () => {
]);

expect(listener.messages).toEqual([
{
role: 'user',
content: 'can you tell me how many properties are in {"a": 1, "b": 2, "c": 3}',
},
{
role: 'assistant',
content: null,
Expand Down Expand Up @@ -1207,7 +1197,6 @@ describe('resource completions', () => {
]);

expect(listener.messages).toEqual([
{ role: 'user', content: 'tell me what the weather is like' },
{
role: 'assistant',
content: null,
Expand Down Expand Up @@ -1413,7 +1402,6 @@ describe('resource completions', () => {
]);

expect(listener.messages).toEqual([
{ role: 'user', content: 'tell me what the weather is like' },
{
role: 'assistant',
content: null,
Expand Down