fix(embeddings): add null/undefined checks for malformed responses #1647
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
Add defensive null/undefined checks for malformed embedding responses to prevent runtime crashes when using third-party OpenAI-compatible endpoints.
Core changes:
Test coverage:
makeClientWithCustomResponse
for custom mock responsesAdditional context & links
Bug: #1542
This addresses potential runtime errors when third-party providers (Ollama, LM Studio) return malformed responses with null/undefined embedding data. The current code lacks defensive checks:
Impact:
✅ I understand that this repository is auto-generated, and my pull request may not be merged