-
-
Notifications
You must be signed in to change notification settings - Fork 261
fix: Errors in allOf behaviour #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Errors in allOf behaviour #363
Conversation
|
Fixing the e2e errors now... |
62956c6 to
e2d3094
Compare
3d33a68 to
efa5e95
Compare
Codecov Report
@@ Coverage Diff @@
## main #363 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 46 46
Lines 1508 1521 +13
=========================================
+ Hits 1508 1521 +13
Continue to review full report at Codecov.
|
8654b96 to
87beb77
Compare
|
@dbanty ready for review now, it would be great if we can get this in the next release! |
|
I think merging #361 made main conflict with your branch 😬 sorry about that. Please pull in the changes and resolve the conflicts when you get a chance. |
2dd8247 to
7ea91b6
Compare
|
Ok this is much simpler now! That previous PR fixed a lot of my issues, and I decided not to bother with full-on merging of allOf schemas because it's a bit of an edge case. However I've kept the old branch in case we ever want to resurrect it. I might have another PR for you later this week to fix an issue with multipart introduced by another recent PR... might be good to get them both in the next release if possible. PS Thanks for this library, it's lovely :) |
7ea91b6 to
dcf5733
Compare
|
@dbanty Now rebased |
dbanty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent job, thanks for fixing this!
I discovered some issues with the handling of
allOf, this should fix them!