Skip to content

feat: Allow path parameters to be positional args [#429]. Thanks @tsotnikov! #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 15, 2021
Merged

feat: Allow path parameters to be positional args [#429]. Thanks @tsotnikov! #464

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d6ece0a
Path parameters as function positional arguments
tsotnikov May 14, 2021
b90bb6a
Ensure path parameters are ordered by appearance in path
tsotnikov May 18, 2021
f06947a
Fix unused fstring
tsotnikov May 18, 2021
e958fd8
Improve sort of path parameters
tsotnikov May 25, 2021
c89129f
Pass endpoint instead of endpoint.path_parameters to ParseError
tsotnikov May 25, 2021
7dece0f
refactor: Rebase on main, make Endpoint publicly-called methods public.
dbanty Aug 7, 2021
aa63b86
fix: Update for rebase on main
dbanty Aug 15, 2021
20f17b8
test: Add test for multiple path params with constants interspersed.
dbanty Aug 15, 2021
f0fe788
fix: OrderedDict typing on older Pythons
dbanty Aug 15, 2021
b672f24
ci: Add test for extra path param
dbanty Aug 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
ci: Add test for extra path param
  • Loading branch information
@dbanty
dbanty committed Aug 15, 2021
commit b672f24199a5cca86052514f0cebb4003c0519ba
16 changes: 15 additions & 1 deletion tests/test_parser/test_openapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,7 +814,7 @@ def test_sort_parameters(self, string_property_factory):

assert result_names == expected_names

def test_sort_parameters_invalid_path_templating(self, string_property_factory):
def test_sort_parameters_missing_param(self, string_property_factory):
from openapi_python_client.parser.openapi import Endpoint

endpoint = self.make_endpoint()
Expand All @@ -828,6 +828,20 @@ def test_sort_parameters_invalid_path_templating(self, string_property_factory):
assert "Incorrect path templating" in result.detail
assert endpoint.path in result.detail

def test_sort_parameters_extra_param(self, string_property_factory):
from openapi_python_client.parser.openapi import Endpoint

endpoint = self.make_endpoint()
endpoint.path = "/multiple-path-parameters"
param = string_property_factory(name="param1")
endpoint.path_parameters[param.name] = param

result = Endpoint.sort_parameters(endpoint=endpoint)

assert isinstance(result, ParseError)
assert "Incorrect path templating" in result.detail
assert endpoint.path in result.detail

def test_from_data_bad_params(self, mocker):
from openapi_python_client.parser.openapi import Endpoint

Expand Down