Carelink update #1276
Merged
Carelink update #1276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
As far as I know, the code just checks if the word "carelink" is part of the punp.ini. I think carelin = on sends the wron signal to the users, since they might guess carelink = off would deactivate it. I suggest to use "radio_type = carelink". |
Contributor
|
I would agree that would be slightly better language and have the same effect. Please do PR in a change. |
Contributor
|
(Working on a code fix for this, help testing openaps/oref0#1011 would be appreciated to see if this resolves automatically upon setup rather than requiring people to manually edit the file. Thanks!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.