Add readme #21
Closed
Add readme #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "package.json" file indicated that this repository is under MIT license, Copyright Scott Leibrand. However, this wasn't clearly visible in the source code, and there was no accompanying license text. I've added copyright notices and licenses to each file, along with a disclaimer. If any item here is not under MIT copyright, or under the copyright of someone other than Scott Leibrand, please let us know. We will rectify the issue as soon as possible. Additional changes: - Removed a large number of commented-out items from dnsmasq.conf, so that there's no ambiquity about copyright. The commented-out items are documentation from the dnsmasq project, which is released under GPL. See http://www.thekelleys.org.uk/dnsmasq/doc.html
danamlewis
added a commit
that referenced
this pull request
Sep 16, 2015
This is following up on #21 (@oskarpearson's suggested README - wasn't sure how else to put in my suggestions so doing it here). Here's my $.02 on what should be articulated in the readme, looking forward to additional input. cc @channemann and @scottleibrand for review; @bewest @audiefile and @Alimazaheri have already given some initial input.
Merged
|
(Couldn't figure out how to suggest my changes, so just created a patch that I think is #31 and everyone should be tagged there to review. Thanks @oskarpearson for kickstarting this!) |
|
Did @oskarpearson 's work make it in? I took a look and it looks like things got included? |
|
I believe everything here got merged already. @oskarpearson please let us know if we missed anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add README file. Note that this requires #20 to be merged, since it refers to the LICENSE.txt file. Have a look at the second commit 'Added README' for details.
I've split these changes into two separate PRs, since the content of the warning and the README might need to go through more revision than the Copyright change. I didn't want to hold up the Copyright change.