add prefs for phones that can support advanced bt tethering #1043
Conversation
bt_with_wifi: allow bt tether while rig also has a wifi connection. bt_offline: keep bt tether steady even when there is no internet not all phones will support these, but with them our samsung galaxy s7 will stay connected to the rig regardless of wifi, so we can always use the offline flask served pages, with or without internet, and the rig will still use wifi (either via its own wifi or the phone's) when available, even when bt tethered.
restore change missing in prior commit
|
At least part of this seems similar to #855, which I'm also a fan of. Or am I missing something? Is there less overlap here than I think? |
|
thanks for pointing that out - if i had any clue how to view a pull requests' code i would compare the changes there to mine... any tips? |
|
Sure! The easiest way is to click the Files Changed tab on the PR itself. It'll show you each of the files changed (in this case just one) and all the additions/deletions made. https://github.com/openaps/oref0/pull/855/files |
|
thanks, sometimes i can't see which text is clickable ;) yes, it looks similar as far as keeping bt going under a wifi connection, but i've also made it not break the bt connection when there is no ip connection, which is helpful when completely offline. |
|
Although it says something about how badly a change like these is needed that I came up with about the same one separately. I'd rather see 855 get in and make changes from there if it would help get one if these in sooner. |
|
I'm a fan of the option for a full-time BT connection regardless of which PR gets merged, but agree with you that if it takes a crawl-walk-run approach by doing #855 and then follow up changes from you it would get us where we want to go! |
|
The reason something like #855 hasn’t been merged is it seems that folks with Android phones suggest lots of things that would work great with Android, but would make for a worse user experience with iOS. I think we need someone with both kinds of phones to test all the potential changes to see which are improvements across both platforms and which help on one but hurt on the other. We might end up needing different behaviors configurable for which kind of phone you have. |
|
Both of the pull requests use preferences to enable the new behavior. And,
at least this pull request, should not change the flow of the script
without the new pref being enabled. So not supported in iPhone should not
block this. I have an iPhone and am pretty sure these prefs won't help it.
…On Sun, Jun 24, 2018, 6:59 PM Scott Leibrand ***@***.***> wrote:
The reason something like #855 <#855>
hasn’t been merged is it seems that folks with Android phones suggest lots
of things that would work great with Android, but would make for a worse
user experience with iOS. I think we need someone with both kinds of phones
to test all the potential changes to see which are improvements across both
platforms and which help on one but hurt on the other.
We might end up needing different behaviors configurable for which kind of
phone you have.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1043 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ATtYodrvafHyt1jVZFw1889o8mi3vTWsks5uADXxgaJpZM4U1Qq9>
.
|
scottleibrand
left a comment
scottleibrand
left a comment
There was a problem hiding this comment.
We should probably use the new bash functions for checking preferences.json. We’ll also need to fix the tabs vs. spaces mismatch.
|
Ok, I like preference gated non-default options for new stuff. I’ll review this in more detail after ADA. |
|
Let's rebase this only 0.7.0-dev so we can use all the fancy new bash function stuff. :-) I just created a branch to make that easier: https://github.com/openaps/oref0/compare/0.7.0-dev...1043-to-0.7.0-dev?expand=1 |
|
i'm not on 0.7.0-dev yet, but have been meaning to setup a pi hat for a while. let me know if you need something from me for this & i'll try to catch up in the meantime. |
|
#1048 merged: please test 0.7.0-dev to confirm that it works properly |
3 participants
bt_with_wifi: allow bt tether while rig also has a wifi connection.
bt_offline: keep bt tether steady even when there is no internet
not all phones will support these, but with them our samsung galaxy s7 will stay connected to the rig regardless of wifi, so we can always use the offline flask served pages (using android firefox, not chrome, due to its offline support), with or without internet, and the rig will still use wifi (either via its own wifi or the phone's) when available, even when bt tethered.