-
Notifications
You must be signed in to change notification settings - Fork 400
Autosens-history & other autosens tweaks #1061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…or running into errors
Conflicts: bin/oref0-autosens-history.js
|
Tried to run autosens-history and running into the following. It's not clear why this is happening: |
|
Are you trying to run it on OpenHumans data? If not, there’s no need to run the new history scripts: they’re only for retrospective analysis of OH data. We just need you to test that the changes to the lib files don’t break normal autosens operation. |
|
I’m trying to run the retrospective analysis to look back over some data I have. Figured out I need to create a participant and give it data from NightScout, which sits in the participant/direct-sharing-31 directory, but not clear why it’s failing at the lib/profile/basal point. |
|
Does your data have a valid profile.json? |
|
I've pulled the profile.json from Nightscout. Let me try it again with the valid one from looping. |
|
Replacing profile.json with a current active one results in the following, which appears to be dumping out at the same place. It appears to be having problems with basal according to 2018-07.out: |
|
@tim2000s Do you have any reason to think this is a problem with the changes in this branch? Or have you seen any regressions in normal autosens use? Or are we good to merge this to dev? |
|
I’ve seen nothing to suggest that autosens of its own accord is affected by the changes. Only the history functions causing me issues. |
|
Ok, I’ll merge this then if no objections. Want to hit me up on Slack or Gitter sometime to troubleshoot the history stuff? |
|
Will do. Probably be later this week. |
This set of autosens tweaks was created to enable us to run autotsens retrospectively on data. There are a few small tweaks, however, that we'd like to test before merging this to dev. Please check out this branch, watch your autosens carefully & let us know if you see anything odd.