Full pumphistory refresh after bolus/enact if no new BG yet #1082
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen intermittent reports in Gitter of what looks like it might be a race condition around incremental pumphistory refreshes during bolus wizard events, which can cause the carb portion of the bolus wizard record to be recorded but not the insulin portion. This presents a safety issue, so to mitigate it this PR performs a full pumphistory refresh at the end of any loop where a bolus is delivered or a temp basal is set, and there's time before the next BG comes in and we need to start the next loop. This should dramatically shrink the window in which a bad incremental pumphistory refresh could impact dosing decisions, without negatively impacting loop speed or reliability.