Stop local go binaries before overwriting. Fixes #1049. #1134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alimhassam
reviewed
Oct 3, 2018
ivalkou
pushed a commit
to ivalkou/oref0
that referenced
this pull request
Nov 27, 2018
…ps#1134) * Stop local go binaries before overwriting. Fixes openaps#1049. * Use prompt_yn function to prompt user
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the local go binaries are running, the copy will fail and setup will die. This PR asks the user if it's okay to kill any running binaries and then kills them if requested.
My editor also auto-fixed some inconsistent spacing; lmk if this should be undone.