-
Notifications
You must be signed in to change notification settings - Fork 400
Wip/offline xdrip #1139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wip/offline xdrip #1139
Conversation
bin/oref0-get-ns-entries.js
Outdated
| // console.error("Load from xDrip failed"); //", trying Spike"); | ||
| // loadFromSpike(); | ||
| } | ||
| process.exit(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation.
| "extra": { | ||
| "fields": "", | ||
| "cmd": "bash -c \"curl --compressed -m 30 -s $NIGHTSCOUT_HOST/api/v1/entries/sgv.json?count=1000 | json -e \\\"this.glucose = this.sgv\\\"\"", | ||
| "cmd": "bash -c \"oref0-get-ns-entries cgm/ns-glucose.json $NIGHTSCOUT_HOST $API_SECRET\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just delete this “device” instead of updating it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure if it's not used anywhere
|
I'm horrible at reading code, but it looks like this does what we're talking about in #1064 ? |
|
Haven't tried it, but the 192.168.43.1 address may not always be correct- in my situation it would work on my phone's wifi hotspot, but the bluetooth link goes up on 192.168.44.* . In my pull request above I ended up using the local gateway address (so it'd work for either), but I never tested if that could have other downsides. |
|
@dramageek Yes this seems to do what #1064 discusses. Wonder if using the default gateway IP is the best way to go? I bet it works most of the time but I wonder if there's an Android fork that does something funky |
|
Looks like the npm network package is working correctly on our devices |
…re a new reading was available out misformatted data
|
Resolved merge conflicts. Is this still WIP? Is it something we want to merge to dev for 0.7.0? |
|
@sulkaharo @dramageek any comments on the status of this PR? |
|
@sulkaharo @dramageek can you update on status? trying to decide which remaining open PRs should be targeted toward the upcoming 0.7.0 release... |
|
This should be good to go, but still needs testing. I've had a couple of hardware failures on both my rigs, so I'm unable to test it. |
|
@danamlewis We've had it on our production rig and after the latest fixes in the PR in January, we haven't had any issues, including offline looping working in a boat, plane and at school. The only hassle this hasn't fixed is the Phone hotspot not turning on automatically when the phone is rebooted. |
|
Closing in favor or #1248 |
Realized I hadn't PRd this, so here's a wip pass to replace my extremely hacky earlier integration. This was made against MASTER, causing the issue templates to pop up as well.
Let's discuss how / if we want to proceed