Consolidate duplicated percentile(); remove unused percentRank(); return result directly without trivial local variable #1144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ial local variable
edwingustafson
changed the title
edwingustafson
changed the title
edwingustafson
changed the title
lib/autotune/index.js
Outdated
| @@ -1,3 +1,5 @@ | |||
| const percentile = require('../percentile') | |||
Contributor
There was a problem hiding this comment.
Is this the first instance of const in this code? We've generally avoided it so far (in favor of var) because some people are still using old versions of node that barf on const.
Contributor
Author
There was a problem hiding this comment.
Happy to follow that policy, this pull request now imports percentile with var not const.
(I did find one other module using const though.
https://github.com/openaps/oref0/blob/master/lib/iob/calculate.js#L38 )
scottleibrand
approved these changes
Nov 18, 2018
ivalkou
pushed a commit
to ivalkou/oref0
that referenced
this pull request
Nov 27, 2018
…urn result directly without trivial local variable (openaps#1144) * Use endsWith from Lodash * Return function results directly (without trivial local variable) * Eliminate another case of function returning trivial local variable * Another opportunity to directly return function result without a trivial local variable * Consolidate redundant functions "percentile"; remove unused function "percentRank" * Import percentile with var not const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.