Skip to content

Conversation

@scottleibrand
Copy link
Contributor

Reverts #1152 due to breakage of npm run global-install - https://gitter.im/nightscout/intend-to-bolus?at=5bfb7577a115c91ef7932640

@edwingustafson can you see if you can figure out what about this commit is causing the issue?

@scottleibrand scottleibrand merged commit 933ab23 into dev Nov 26, 2018
@scottleibrand scottleibrand deleted the revert-1152-dev branch November 26, 2018 09:17
@edwingustafson
Copy link
Contributor

Not sure how adding a new script lint could interfere with existing one global-install. But I can resubmit the ESLint configuration files only, without adding eslint to the project. That is sufficient to provide editor warnings.

@scottleibrand
Copy link
Contributor Author

Yeah, I don't know why that's a problem. I can't really test it effectively myself, as when I don't seem to have eslint installed:

~/src/oref0 $ npm run lint

> [email protected] lint /home/sleibrand/src/oref0
> eslint .

sh: 1: eslint: not found

But I agree, just leaving the npm stuff reverted and re-PR'ing the other stuff should be safe.

ivalkou pushed a commit to ivalkou/oref0 that referenced this pull request Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants