Missing and redundant variable declarations #1172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ial local variable
scottleibrand
approved these changes
Dec 16, 2018
Contributor
|
Looks like checks are failing. Want to take a first look at that before I do? |
…st "IOB should calculate IOB without counting time pump suspended in middle of basal"
Contributor
Author
|
Reverted changes in |
cluckj
reviewed
Feb 11, 2019
cluckj
reviewed
Feb 11, 2019
Contributor
Author
|
Not sure why neither ESLint nor the project's unit tests reported these in my fork, but it looks like your pull requests 1198 and 1199 solved them. Sorry for the trouble! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add or remove variable declarations for variables ESLint found to be undeclared or redeclared