restore ww pumps for 0.7.0-dev #1176

PieterGit · 2018-12-25T12:46:02Z

With a fresh install with a WW pump, the rig could not communicate to the pump.

removing python oref0_init_pump_comms.py and oref0_subg_ww_radio_parameters.py (not needed with Go libaries)
use .travis with latest Node 8 LTS and Node 10 LTS versions
docfix: update version numbers of Go libraries to version with tokenbased authentication
remove --ww_ti_usb_reset
remove oref0 dependencies on pump.ini
fix jq install problem, and don't install master version of oref0 by default on bin/openaps-packages.sh. It will be installed by oref0-setup.sh
read pump.ini stuff from preferences.json instead of pump.ini
mmtune fix if does not exist on install
mmtune fix: die in bin/oref0-mmtune.sh if monitor/mmtune.json is empty or does not exist
fix for mmeowlink if you're not a mdt cgm user
removed radio_locale pump.ini hacks
update npm libraries

Status: Ready for merge to dev, when @scottleibrand thinks it's ready.

…c1 go libraries. this will also remove ti usb reset support

…an else block

bin/oref0-setup.sh

…s a switch in preferences.json. WIP to remove use of pump.ini in favor of storing pump serial, radio locale, and tty port in preferences.json.

this removes warning: npm WARN deprecated [email protected]: This package is no longer supported. It's now a built-in Node module. If you've depended on crypto, you should switch to the one that's built-in.

jq: Unknown option --slurpfile Use jq --help for help with command-line options, or see the jq documentation at http://stedolan.github.com/jq module.js:675 throw err; ^ SyntaxError: /root/myopenaps/updated_prefs.json: Unexpected end of JSON input at JSON.parse (<anonymous>) at Object.Module._extensions..json (module.js:672:27) at Module.load (module.js:566:32) at tryModuleLoad (module.js:506:12) at Function.Module._load (module.js:498:3) at Module.require (module.js:597:17) at require (internal/module.js:11:18) at Object.<anonymous> (/home/.rootfs/usr/local/lib/node_modules/oref0/bin/oref0-get-profile.js:81:23) at Module._compile (module.js:653:30) at Object.Module._extensions..js (module.js:664:10) Could not run oref0-get-profile --- # jq --version jq-1.4-1-e73951f

scottleibrand

I don’t think changing the install script names is necessary or necessarily a good idea. Coordinating changes between the code and documentation, especially when changes made to dev don’t go to master right away, is difficult and causes confusion.

…sie-backports if using older debian version (e.g. on jubilinux 0.2.x )

…v. Also update moment and change share2nightscout-bridge to released version 0.2.0 # Conflicts: # package.json

…ott suggests, keep jq fix for debian_jessie

bin/oref0-setup.sh

PieterGit · 2019-02-17T16:14:07Z

@scottleibrand I think i fixed all your open review remarks. Can you please re-rereview. I will test on a fresh edison and rpi later.

…the major changes and could not find deprecations we use

scottleibrand · 2019-02-17T17:19:53Z

Looks like there's a conflict between @cclauss' and @PieterGit's recent changes to .travis.yml.
@PieterGit did:

node_js:
  - 8
  - 10

whereas @cclauss did:

matrix:
  include:
    - node_js: "8.11.1"
      <<: *node_js-steps

Which do y'all prefer?

scottleibrand

Thanks @PieterGit - once the merge conflict is fixed, this LGTM.

cclauss · 2019-02-17T18:47:59Z

#1203 Perhaps:

matrix:
  include:
    - node_js: “8”
      <<: *node_js-steps
    - node_js: “10”
      <<: *node_js-steps
    - node_js: “node”
      <<: *node_js-steps

…0-setup.sh will install it when it's run

As discussed at #1176 (comment)

``` # oref0-mmtune mmtune: WW 2019/02/17 23:04:04 cannot connect to CC111x radio on /dev/spidev5.1 2019/02/17 23:04:04 cc111x: no response Usage: grep [OPTION]... PATTERN [FILE]... Try 'grep --help' for more information. ```

@PieterGit

@PieterGit isn't ready to merge yet

…eeded for mdt CGM, try to see if we can get mmeowlink back to work if users specifies port with mmeowlink in it 3) add todo's

PieterGit · 2019-02-20T16:14:05Z

spi_serial and mraa don't seem to be needed for 754WW pump

@scottleibrand Tested on a explorer board and with WW-pump and it works. I think it's r eady for further test, review and merge.
@cluckj can you also review this PR?
@tepidjuice can you see if you're radio comms problems is solved with this PR?

cluckj · 2019-02-20T16:16:44Z

bin/oref0-setup.sh

-            grep -q radio_locale pump.ini ||  echo "$(< pump.ini)" > pump.ini ; echo "radio_locale=$radio_locale" >> pump.ini
        fi
-    else
+    else # in all other case create a pump.ini with serial and radio_locale. TODO: can we skip creating a pump.ini. I can't find references of it's being used


I think that xdrip-js uses pump.ini, we should let them know before removing it: @efidoman @jpcunningh @thebookins

i don't want to suggest to remove it now. As far as I can see I removed all the references to the pump.ini from the oref0 code base. I hope @efidoman @jpcunningh @thebookins can say if their software somehow uses pump.ini. I just checked Lookout, but can't find any reference: https://github.com/xdrip-js/Lookout/search?q=pump.ini&unscoped_q=pump.ini

The only use might be for fakemeter, which is here: https://github.com/xdrip-js/Logger/blob/f7228485c7a66300f280ac789b5dce0252ffa279/xdrip-get-entries.sh#L245

Created xdrip-js/Logger#137 for that

PieterGit · 2019-02-24T08:50:02Z

rig is running fine for 4 days. Didn't find issues. I think this PR is ready to merge to dev.
@scottleibrand can you review and merge to dev when you think it's ready?

PieterGit · 2019-03-01T08:29:54Z

I resolved the conflict with the dev branch. Rig is used as primary rig, and didn't find issues for a week.
@scottleibrand Can you please review and merge to dev if you think it's ok?

cclauss

Comma missing at end of line 110?

PieterGit · 2019-03-02T11:16:55Z

@cclauss thanks. fixed it with the Github UI. re-applied.
@scottleibrand please merge to dev

scottleibrand · 2019-03-05T05:18:05Z

This LGTM. Once we iron out the issues with dev and decide if webpack is staying or going, I'll fix the merge conflicts and confirm tests pass before merging.

PieterGit · 2019-03-10T21:04:17Z

Thanks for merging. Up to the next PR.

…s#1176

efidoman · 2019-04-01T14:20:15Z

I remembered that having this variable set is no longer necessary for fakemeter, so I tested Logger with that line deleted and fakemeter works fine. In addition, the fakemeter processing has moved in the latest Logger and OpenAPS dev branches to process as part of the OpenAPS loop. I'll update the Logger code and remove this line.

efidoman · 2019-04-01T14:35:23Z

All references to pump.ini have been removed from the Logger dev branch.

* Fix for x12 status check * Spacing * Remove workarounds for missing x12 settings * Remove workarounds for missing x12 settings * Spacing... * Improving automation of hardware setups, support for more kinds of Go binaries, x12 cleanup. * Update installer options, deprecate MDT, conflict changes with #1176 * Deprecate G4-upload and G4-local-only, setup readability * Bugfixes, cleanup, and deprecate mmeowlink... * Refactor interactive setup... * Refactor, can ensure building from source for certain setups without binaries * Better support for custom radiotags and diy radios * Comments, and activate SPI only on the Pi * Typo... * Restore mmeowlink * Missing quotation marks * Move updating jq earlier in the install script Some jq calls between lines 683 and 1132 need `sub`, which is only supported in newer versions of jq... * Revert to original repo, and do the config change with sed * Additional comments, remove redundant jq installs

PieterGit added 6 commits December 25, 2018 13:11

update example Go versions to verison with token based authentication

8ee8483

run travis with latest node 8 and node 10 (both LTS)

c6ea53e

remove init pump comms to set ww parameters. this is now done with ec…

d45d29c

…c1 go libraries. this will also remove ti usb reset support

fix duplicate radio_locale in pump.ini and don't run default code in …

5e15e18

…an else block

create pump.ini before nightscout autoconfigure-device-crud

e54bdbe

remove ww_ti_usb_reset

459c2e2

scottleibrand reviewed Dec 25, 2018

View reviewed changes

bin/oref0-setup.sh Outdated Show resolved Hide resolved

bin/oref0-setup.sh Outdated Show resolved Hide resolved

PieterGit and others added 7 commits December 25, 2018 18:22

remove extra empty line

5b720b1

WIP to deprecate old MDT CGM setup (new MDT CGM Go stuff just require…

1d73dbb

…s a switch in preferences.json. WIP to remove use of pump.ini in favor of storing pump serial, radio locale, and tty port in preferences.json.

remove depreacte medtronic non Go setup

4971861

rename openaps-*.sh to oref0-*.sh and adjust

ac43e91

remove crypto 0.0.3, it is included in Node

889cca7

this removes warning: npm WARN deprecated [email protected]: This package is no longer supported. It's now a built-in Node module. If you've depended on crypto, you should switch to the one that's built-in.

update npm packages

e94cc78

scottleibrand reviewed Dec 27, 2018

View reviewed changes

PieterGit added 7 commits December 27, 2018 15:59

Introduce is_debian_jessie function and use it to install jq from jes…

1e2ac27

…sie-backports if using older debian version (e.g. on jubilinux 0.2.x )

still add openaps to oref0-packages for now

620ea30

remove creation of pump.ini as scott suggests

a679bd9

Merge branch 'dev' of https://github.com/openaps/oref0 into 201812_de…

9bad0e2

…v. Also update moment and change share2nightscout-bridge to released version 0.2.0 # Conflicts: # package.json

revert ac43e91 renaming as scott suggests

60aa85c

switch back to openaps-packages.sh instead of oref0-packages.sh as sc…

300a100

…ott suggests, keep jq fix for debian_jessie

on a fresh rpi3 there is no /usr/local/bin/mmtune so don't move it

9204022

scottleibrand reviewed Feb 10, 2019

View reviewed changes

bin/oref0-setup.sh Show resolved Hide resolved

bin/oref0-setup.sh Show resolved Hide resolved

bin/oref0-setup.sh Outdated Show resolved Hide resolved

PieterGit added 2 commits February 17, 2019 16:40

Merge branch 'dev' of https://github.com/openaps/oref0 into 201812_dev

2c3d41b

implement changes as requested by scott

9defb3c

upgrade yargs to avoid security vulnerability . did a quick check of …

d7c8a27

…the major changes and could not find deprecations we use

scottleibrand previously approved these changes Feb 17, 2019

View reviewed changes

there is no need to install the released oref0 globally, because oref…

54a0f25

…0-setup.sh will install it when it's run

scottleibrand pushed a commit that referenced this pull request Feb 17, 2019

Travis CI: Run node_js tests on "8", "10", and "node" (#1203)

5489732

As discussed at #1176 (comment)

prevent spurious grep message if monitor/mmtune.json is empty

e074d61

``` # oref0-mmtune mmtune: WW 2019/02/17 23:04:04 cannot connect to CC111x radio on /dev/spidev5.1 2019/02/17 23:04:04 cc111x: no response Usage: grep [OPTION]... PATTERN [FILE]... Try 'grep --help' for more information. ```

PieterGit added 3 commits February 20, 2019 15:25

Merge branch 'dev' of https://github.com/openaps/oref0 into 201812_dev

eb4d387

1) cleanup ugly pump.ini stuff for edison. 2) mmeowlink is not only n…

3b731e3

…eeded for mdt CGM, try to see if we can get mmeowlink back to work if users specifies port with mmeowlink in it 3) add todo's

add missing then

07eba20

cluckj reviewed Feb 20, 2019

View reviewed changes

PieterGit mentioned this pull request Feb 20, 2019

Please remove dependency on $HOME/myopenaps/pump.ini xdrip-js/Logger#137

Closed

PieterGit and others added 2 commits March 1, 2019 07:59

Merge branch 'dev' into 201812_dev

641fbdd

fix package.json typo and upgrade coveralls to 3.0.3

ea1d009

cclauss reviewed Mar 1, 2019

View reviewed changes

Merge branch 'dev' into 201812_dev

8d4f608

remove webpack from this branch

4f95a21

PieterGit added 2 commits March 9, 2019 12:16

upgrade share2nightscout bridge and yargs

3665309

Merge branch 'dev' of https://github.com/openaps/oref0 into 201812_dev

7a809c9

scottleibrand merged commit 850545b into openaps:dev Mar 10, 2019

cluckj mentioned this pull request Mar 12, 2019

Fix check for WW pumps #1229

Merged

cluckj added a commit to cluckj/oref0 that referenced this pull request Mar 14, 2019

Update installer options, deprecate MDT, conflict changes with openap…

997e14a

…s#1176

cluckj added a commit to cluckj/oref0 that referenced this pull request Mar 14, 2019

Update installer options, deprecate MDT, conflict changes with openap…

f7341ef

…s#1176

cluckj mentioned this pull request Mar 16, 2019

Inverted logic fix for oref0-mmtune.sh, and bug fix for oref0-pump-loop.sh #1230

Merged

restore ww pumps for 0.7.0-dev #1176

restore ww pumps for 0.7.0-dev #1176

Uh oh!

Conversation

PieterGit commented Dec 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

scottleibrand left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PieterGit commented Feb 17, 2019

Uh oh!

scottleibrand commented Feb 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

scottleibrand left a comment

Choose a reason for hiding this comment

Uh oh!

cclauss commented Feb 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PieterGit commented Feb 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cluckj Feb 20, 2019

Choose a reason for hiding this comment

Uh oh!

PieterGit Feb 20, 2019

Choose a reason for hiding this comment

Uh oh!

cluckj Feb 20, 2019

Choose a reason for hiding this comment

Uh oh!

PieterGit Feb 20, 2019

Choose a reason for hiding this comment

Uh oh!

PieterGit commented Feb 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PieterGit commented Mar 1, 2019

Uh oh!

cclauss left a comment

Choose a reason for hiding this comment

Uh oh!

PieterGit commented Mar 2, 2019

Uh oh!

scottleibrand commented Mar 5, 2019

Uh oh!

PieterGit commented Mar 10, 2019

Uh oh!

efidoman commented Apr 1, 2019

Uh oh!

efidoman commented Apr 1, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

PieterGit commented Dec 25, 2018 •

edited

Loading

scottleibrand commented Feb 17, 2019 •

edited

Loading

cclauss commented Feb 17, 2019 •

edited

Loading

PieterGit commented Feb 20, 2019 •

edited

Loading

PieterGit commented Feb 24, 2019 •

edited

Loading